Skip to content

Conversation

ioanatia
Copy link
Contributor

@ioanatia ioanatia commented Oct 14, 2024

Noticed I have these generated changes for HypotEvaluator which was recently added in #114382

These changes seem inline with the current version of X-InEvaluator.java.st so maybe the initial HypotEvaluator was manually edited.

Requested a review from the author and reviewers of the initial PR.

@ioanatia ioanatia added >non-issue auto-backport Automatically create backport pull requests when merged :Analytics/ES|QL AKA ESQL v8.16.0 labels Oct 14, 2024
@ioanatia ioanatia requested a review from limotova October 14, 2024 07:56
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine elasticsearchmachine added v9.0.0 Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) labels Oct 14, 2024
Copy link
Contributor

@ivancea ivancea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ioanatia ioanatia merged commit 30ff474 into elastic:main Oct 14, 2024
16 checks passed
@ioanatia ioanatia deleted the missing_evaluator branch October 14, 2024 09:05
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

The backport operation could not be completed due to the following error:

An unexpected error occurred when attempting to backport this PR.

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 114697

@limotova
Copy link
Contributor

I think when I first opened the PR it was before db8a2d2 was added, and then I never re-generated those files. Sorry about that, I'll keep that in mind for next time..!

davidkyle pushed a commit to davidkyle/elasticsearch that referenced this pull request Oct 14, 2024
georgewallace pushed a commit to georgewallace/elasticsearch that referenced this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/ES|QL AKA ESQL auto-backport Automatically create backport pull requests when merged >non-issue Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.16.0 v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants