Skip to content

Conversation

kkrik-es
Copy link
Contributor

Pass-through objects were added a few months ago but never documented, treaded as experimental.

# Conflicts:
#	server/src/main/java/org/elasticsearch/common/settings/IndexScopedSettings.java
#	server/src/main/java/org/elasticsearch/index/IndexSettings.java
@kkrik-es kkrik-es added >docs General docs changes auto-backport Automatically create backport pull requests when merged :StorageEngine/TSDB You know, for Metrics Team:StorageEngine :StorageEngine/Mapping The storage related side of mappings v8.16.0 labels Oct 14, 2024
@kkrik-es kkrik-es self-assigned this Oct 14, 2024
Copy link
Contributor

Documentation preview:

@kkrik-es kkrik-es marked this pull request as ready for review October 14, 2024 14:15
@elasticsearchmachine elasticsearchmachine added the Team:Docs Meta label for docs team label Oct 14, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kkrik-es kkrik-es enabled auto-merge (squash) October 15, 2024 09:21
@kkrik-es kkrik-es merged commit 4d775cb into elastic:main Oct 15, 2024
15 of 16 checks passed
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

The backport operation could not be completed due to the following error:

An unexpected error occurred when attempting to backport this PR.

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 114720

@kkrik-es
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.x

Questions ?

Please refer to the Backport tool documentation

kkrik-es added a commit to kkrik-es/elasticsearch that referenced this pull request Oct 15, 2024
* Guard second doc parsing pass with index setting

* add test

* updates

* updates

* merge

* Add documentation for passthrough field type

* Apply suggestions from code review

Co-authored-by: Felix Barnsteiner <[email protected]>

* updates

* updates

* Update docs/reference/mapping/types/passthrough.asciidoc

Co-authored-by: Felix Barnsteiner <[email protected]>

* address comment

* address comment

* Update docs/reference/mapping/types/passthrough.asciidoc

Co-authored-by: Felix Barnsteiner <[email protected]>

* address comment

---------

Co-authored-by: Felix Barnsteiner <[email protected]>
(cherry picked from commit 4d775cb)
elasticsearchmachine pushed a commit that referenced this pull request Oct 15, 2024
* Guard second doc parsing pass with index setting

* add test

* updates

* updates

* merge

* Add documentation for passthrough field type

* Apply suggestions from code review

Co-authored-by: Felix Barnsteiner <[email protected]>

* updates

* updates

* Update docs/reference/mapping/types/passthrough.asciidoc

Co-authored-by: Felix Barnsteiner <[email protected]>

* address comment

* address comment

* Update docs/reference/mapping/types/passthrough.asciidoc

Co-authored-by: Felix Barnsteiner <[email protected]>

* address comment

---------

Co-authored-by: Felix Barnsteiner <[email protected]>
(cherry picked from commit 4d775cb)
georgewallace pushed a commit to georgewallace/elasticsearch that referenced this pull request Oct 25, 2024
* Guard second doc parsing pass with index setting

* add test

* updates

* updates

* merge

* Add documentation for passthrough field type

* Apply suggestions from code review

Co-authored-by: Felix Barnsteiner <[email protected]>

* updates

* updates

* Update docs/reference/mapping/types/passthrough.asciidoc

Co-authored-by: Felix Barnsteiner <[email protected]>

* address comment

* address comment

* Update docs/reference/mapping/types/passthrough.asciidoc

Co-authored-by: Felix Barnsteiner <[email protected]>

* address comment

---------

Co-authored-by: Felix Barnsteiner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged backport pending >docs General docs changes :StorageEngine/Mapping The storage related side of mappings :StorageEngine/TSDB You know, for Metrics Team:Docs Meta label for docs team Team:StorageEngine v8.16.0 v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants