Skip to content

Don't close/recreate adaptive allocations metrics #114721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Don't close/recreate adaptive allocations metrics #114721

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions ...lasticsearch/xpack/ml/inference/adaptiveallocations/AdaptiveAllocationsScalerService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,17 +171,6 @@ Collection<DoubleWithAttributes> observeDouble(Function<AdaptiveAllocationsScale
}
return observations;
}

void close() {
for (AutoCloseable metric : metrics) {
try {
metric.close();
} catch (Exception e) {
// do nothing
}
}
metrics.clear();
}
}

/**
Expand Down Expand Up @@ -261,7 +250,7 @@ public synchronized void start() {
public synchronized void stop() {
clusterService.removeListener(this);
stopScheduling();
metrics.close();
scalers.clear();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've leave the metrics list as is and don't recreate them (which leads to errors).

Clearing the scalers collection, so that the metrics do not observe anything anymore.

}

@Override
Expand Down
Loading