Skip to content

Conversation

kkrik-es
Copy link
Contributor

The list with two options doesn't get rendered as a list, due to the snippet in between.

https://www.elastic.co/guide/en/elasticsearch/reference/master/passthrough.html#passthrough-conflicts

@kkrik-es kkrik-es self-assigned this Oct 15, 2024
@kkrik-es kkrik-es added the >docs General docs changes label Oct 15, 2024
Copy link
Contributor

Documentation preview:

@kkrik-es kkrik-es added Team:StorageEngine :StorageEngine/Mapping The storage related side of mappings auto-backport Automatically create backport pull requests when merged v8.16.0 labels Oct 15, 2024
@kkrik-es kkrik-es marked this pull request as ready for review October 15, 2024 11:40
@kkrik-es kkrik-es added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Oct 15, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Docs Meta label for docs team label Oct 15, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@leemthompo
Copy link
Contributor

leemthompo commented Oct 15, 2024

@kkrik-es FYI you can make sure various blocks are tied together in a list using +'s, AKA asciidoc list continuations :

A list continuation is a + symbol on a line by itself, immediately adjacent to the block being attached.

@kkrik-es
Copy link
Contributor Author

@kkrik-es FYI you can make sure various blocks are tied together in a list using +'s, AKA asciidoc list continuations :

A list continuation is a + symbol on a line by itself, immediately adjacent to the block being attached.

Thanks for the suggestion, this is much better.

@elasticsearchmachine elasticsearchmachine merged commit 8cf2cb3 into elastic:main Oct 15, 2024
5 checks passed
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

The backport operation could not be completed due to the following error:

An unexpected error occurred when attempting to backport this PR.

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 114815

@kkrik-es kkrik-es deleted the synthetic-source/second-pass-flag branch October 15, 2024 12:39
@kkrik-es
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.x

Questions ?

Please refer to the Backport tool documentation

kkrik-es added a commit to kkrik-es/elasticsearch that referenced this pull request Oct 15, 2024
The list with two options doesn't get rendered as a list, due to the
snippet in between.

https://www.elastic.co/guide/en/elasticsearch/reference/master/passthrough.html#passthrough-conflicts
(cherry picked from commit 8cf2cb3)
elasticsearchmachine pushed a commit that referenced this pull request Oct 15, 2024
The list with two options doesn't get rendered as a list, due to the
snippet in between.

https://www.elastic.co/guide/en/elasticsearch/reference/master/passthrough.html#passthrough-conflicts
(cherry picked from commit 8cf2cb3)
georgewallace pushed a commit to georgewallace/elasticsearch that referenced this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport pending >docs General docs changes :StorageEngine/Mapping The storage related side of mappings Team:Docs Meta label for docs team Team:StorageEngine v8.16.0 v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants