-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[ML] Increase default queue_capacity to 10_000 and decrease max queue_capacity to 100_000 #115041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core (Team:ML) |
|
Hi @maxhniebergall, I've created a changelog YAML for you. |
…icsearch into trainedModelsQueueCapacity
…odelsQueueCapacity
prwhelan
approved these changes
Oct 23, 2024
💔 Backport failedThe backport operation could not be completed due to the following error: You can use sqren/backport to manually backport by running |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
smalyshev
pushed a commit
to smalyshev/elasticsearch
that referenced
this pull request
Oct 23, 2024
…_capacity to 100_000 (elastic#115041) * Increase default queue capacity and decrease max queue capacity * Update docs/changelog/115041.yaml * Update tests to match new constants
georgewallace
pushed a commit
to georgewallace/elasticsearch
that referenced
this pull request
Oct 25, 2024
…_capacity to 100_000 (elastic#115041) * Increase default queue capacity and decrease max queue capacity * Update docs/changelog/115041.yaml * Update tests to match new constants
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
Nov 4, 2024
…_capacity to 100_000 (elastic#115041) * Increase default queue capacity and decrease max queue capacity * Update docs/changelog/115041.yaml * Update tests to match new constants
ppf2
added a commit
to ppf2/elasticsearch
that referenced
this pull request
Dec 17, 2024
Updating with changes in elastic#115041
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 17, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 17, 2024
rjernst
pushed a commit
to rjernst/elasticsearch
that referenced
this pull request
Dec 18, 2024
Updating with changes in elastic#115041
sarog
pushed a commit
to portsbuild/elasticsearch
that referenced
this pull request
Jan 22, 2025
…tic#118891) Updating with changes in elastic#115041
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Automatically create backport pull requests when merged
backport pending
>enhancement
:ml
Machine learning
Team:ML
Meta label for the ML team
v8.17.0
v9.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default queue_capacity of 1024 has been affecting some customers who experience errors during reindex or when using ingest pipelines. Now that we have automatic chunking, this issue is more common. To prevent customers from running into this issue, we are increasing the default queue_capacity to 10'000. At the same time, we have found that the previous maximum queue_capacity of 1MM was too large, and would cause crashes if filled. We are decreasing it to what we believe is a more realistic value.
The queue_capacity of existing deployments should be unaffected by this change.