Add back snapshot build restriction for match and qstr functions #115253
Conversation
This reverts commit 581894a
carlosdelest
changed the title
carlosdelest
added
Team:Analytics
elasticsearchmachine
removed
the
Team:Analytics
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
carlosdelest
requested review from
ChrisHegarty,
afoucret,
fang-xing-esql,
ioanatia and
tteofili
|
@carlosdelest are we not reverting on 8.17 & 8.18 so its easier to test and develop with? |
@benwtrent the idea is to fix the LIMIT limitations for 8.17. We could of course be cautious and remove it from the 8.x branch - we're just thinking ahead to avoid another change for enabling this on 8.x |
Commits are cheap Regardless, I understand and if its easier to develop against without the flag, then its fine to have it removed in 8x. |
| PROJECT_PIPE : PIPE -> type(PIPE), popMode; | ||
| PROJECT_DOT: DOT -> type(DOT); | ||
| PROJECT_COMMA : COMMA -> type(COMMA); | ||
| PROJECT_PARAM : {this.isDevVersion()}? PARAM -> type(PARAM); |
There was a problem hiding this comment.
are these changes required?
There was a problem hiding this comment.
Thanks for the catch! No they're not - fixed
5 participants
This reverts #114793
match() and qstr() will be back behind snapshot builds on 8.x branches until using them after LIMIT has been addressed, either in the functions themselves or in Kibana side.