ESQL: Skip unsupported grapheme cluster test #115258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This skips the test for reversing grapheme clusters if the node doesn't support reversing grapheme clusters. Nodes that are using a jdk before 20 won't support reversing grapheme clusters because they don't have https://bugs.openjdk.org/browse/JDK-8292387 This reworks `EsqlCapabilities` so we can easilly register it only if we're on jdk 20: ``` FN_REVERSE_GRAPHEME_CLUSTERS(Runtime.version().feature() < 20), ``` Closes elastic#114537 Closes elastic#114535 Closes elastic#114536 Closes elastic#114558 Closes elastic#114559 Closes elastic#114560
nik9000
added
>test
|
Documentation preview: |
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
|
NOTE: This is targeting 8.x and I'll manually forward port a big chunk of it into |
bpintea
approved these changes
Oct 21, 2024
| * Support for reversing whole grapheme clusters. This is not supported | ||
| * on JDK versions less than 20. | ||
| */ | ||
| FN_REVERSE_GRAPHEME_CLUSTERS(Runtime.version().feature() < 20), |
...ql/src/main/java/org/elasticsearch/xpack/esql/expression/function/scalar/string/Reverse.java
Outdated
Show resolved
Hide resolved
…expression/function/scalar/string/Reverse.java Co-authored-by: Bogdan Pintea <[email protected]>
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Oct 22, 2024
This skips the test for reversing grapheme clusters if the node doesn't support reversing grapheme clusters. Nodes that are using a jdk before 20 won't support reversing grapheme clusters because they don't have https://bugs.openjdk.org/browse/JDK-8292387 This reworks `EsqlCapabilities` so we can easilly register it only if we're on jdk 20: ``` FN_REVERSE_GRAPHEME_CLUSTERS(Runtime.version().feature() < 20), ``` Closes elastic#114537 Closes elastic#114535 Closes elastic#114536 Closes elastic#114558 Closes elastic#114559 Closes elastic#114560
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Oct 22, 2024
This skips the test for reversing grapheme clusters if the node doesn't support reversing grapheme clusters. Nodes that are using a jdk before 20 won't support reversing grapheme clusters because they don't have https://bugs.openjdk.org/browse/JDK-8292387 This reworks `EsqlCapabilities` so we can easilly register it only if we're on jdk 20: ``` FN_REVERSE_GRAPHEME_CLUSTERS(Runtime.version().feature() < 20), ``` Closes elastic#114537 Closes elastic#114535 Closes elastic#114536 Closes elastic#114558 Closes elastic#114559 Closes elastic#114560
|
Forward port to main: #115321 |
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Oct 22, 2024
This skips the test for reversing grapheme clusters if the node doesn't support reversing grapheme clusters. Nodes that are using a jdk before 20 won't support reversing grapheme clusters because they don't have https://bugs.openjdk.org/browse/JDK-8292387 This reworks `EsqlCapabilities` so we can easilly register it only if we're on jdk 20: ``` FN_REVERSE_GRAPHEME_CLUSTERS(Runtime.version().feature() < 20), ``` Closes elastic#114537 Closes elastic#114535 Closes elastic#114536 Closes elastic#114558 Closes elastic#114559 Closes elastic#114560
|
Backport to 8.16: #115324 |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 22, 2024
This skips the test for reversing grapheme clusters if the node doesn't support reversing grapheme clusters. Nodes that are using a jdk before 20 won't support reversing grapheme clusters because they don't have https://bugs.openjdk.org/browse/JDK-8292387 This reworks `EsqlCapabilities` so we can easilly register it only if we're on jdk 20: ``` FN_REVERSE_GRAPHEME_CLUSTERS(Runtime.version().feature() < 20), ``` Closes #114537 Closes #114535 Closes #114536 Closes #114558 Closes #114559 Closes #114560
nik9000
added a commit
that referenced
this pull request
Oct 22, 2024
This skips the test for reversing grapheme clusters if the node doesn't support reversing grapheme clusters. Nodes that are using a jdk before 20 won't support reversing grapheme clusters because they don't have https://bugs.openjdk.org/browse/JDK-8292387 This reworks `EsqlCapabilities` so we can easilly register it only if we're on jdk 20: ``` FN_REVERSE_GRAPHEME_CLUSTERS(Runtime.version().feature() < 20), ``` Closes #114537 Closes #114535 Closes #114536 Closes #114558 Closes #114559 Closes #114560
|
Merged! |
georgewallace
pushed a commit
to georgewallace/elasticsearch
that referenced
this pull request
Oct 25, 2024
…c#115321) This skips the test for reversing grapheme clusters if the node doesn't support reversing grapheme clusters. Nodes that are using a jdk before 20 won't support reversing grapheme clusters because they don't have https://bugs.openjdk.org/browse/JDK-8292387 This reworks `EsqlCapabilities` so we can easilly register it only if we're on jdk 20: ``` FN_REVERSE_GRAPHEME_CLUSTERS(Runtime.version().feature() < 20), ``` Closes elastic#114537 Closes elastic#114535 Closes elastic#114536 Closes elastic#114558 Closes elastic#114559 Closes elastic#114560
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
Nov 4, 2024
…c#115321) This skips the test for reversing grapheme clusters if the node doesn't support reversing grapheme clusters. Nodes that are using a jdk before 20 won't support reversing grapheme clusters because they don't have https://bugs.openjdk.org/browse/JDK-8292387 This reworks `EsqlCapabilities` so we can easilly register it only if we're on jdk 20: ``` FN_REVERSE_GRAPHEME_CLUSTERS(Runtime.version().feature() < 20), ``` Closes elastic#114537 Closes elastic#114535 Closes elastic#114536 Closes elastic#114558 Closes elastic#114559 Closes elastic#114560
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This skips the test for reversing grapheme clusters if the node doesn't support reversing grapheme clusters. Nodes that are using a jdk before 20 won't support reversing grapheme clusters because they don't have https://bugs.openjdk.org/browse/JDK-8292387
This reworks
EsqlCapabilitiesso we can easilly register it only if we're on jdk 20:Closes #114537
Closes #114535
Closes #114536
Closes #114558
Closes #114559
Closes #114560