adaptive allocations: reset time interval with zero requests #115400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rting an allocation
jan-elastic
added
>non-issue
:ml
|
Pinging @elastic/ml-core (Team:ML) |
jan-elastic
commented
Oct 23, 2024
|
|
||
| AdaptiveAllocationsScaler scaler = scalers.get(assignment.getDeploymentId()); | ||
| if (scaler != null) { | ||
| scaler.resetTimeWithoutRequests(); |
There was a problem hiding this comment.
If starting an allocation takes too long (longer than the inference request timeout of 10secs), the inference request fails prematurely, and never reaches the allocation. This means that it isn't counted in the node stats, the "timeWithoutRequests" of the autoscaler keeps ticking, and the new allocation is stopped too soon.
jan-elastic
added
v8.17.0
auto-backport
💔 Backport failedThe backport operation could not be completed due to the following error: You can use sqren/backport to manually backport by running |
jan-elastic
added a commit
that referenced
this pull request
Oct 23, 2024
…rting an allocation (#115400)
jan-elastic
added a commit
that referenced
this pull request
Oct 23, 2024
…rting an allocation (#115400)
smalyshev
pushed a commit
to smalyshev/elasticsearch
that referenced
this pull request
Oct 23, 2024
…rting an allocation (elastic#115400)
georgewallace
pushed a commit
to georgewallace/elasticsearch
that referenced
this pull request
Oct 25, 2024
…rting an allocation (elastic#115400)
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
Nov 4, 2024
…rting an allocation (elastic#115400)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.