Skip to content

Conversation

DaveCTurner
Copy link
Contributor

The docs kinda imply that circuit breakers protect against OOMEs, at
least that's how some customers seem to interpret them. This commit adds
a note spelling out that this isn't the case.

The docs kinda imply that circuit breakers protect against OOMEs, at
least that's how some customers seem to interpret them. This commit adds
a note spelling out that this isn't the case.
@DaveCTurner DaveCTurner added >docs General docs changes :Core/Infra/Circuit Breakers Track estimates of memory consumption to prevent overload v9.0.0 v8.16.1 v8.17.0 v8.15.5 labels Nov 4, 2024
Copy link
Contributor

github-actions bot commented Nov 4, 2024

Documentation preview:

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticsearchmachine elasticsearchmachine added Team:Core/Infra Meta label for core/infra team Team:Docs Meta label for docs team labels Nov 4, 2024
@DaveCTurner DaveCTurner requested a review from benwtrent November 4, 2024 15:21
Copy link
Member

@benwtrent benwtrent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New wording seems good.

Do we also want to backport to 7.17?

@DaveCTurner
Copy link
Contributor Author

Yeah ok it looks like it should apply cleanly in 7.17 too.

@DaveCTurner DaveCTurner added v7.17.26 auto-backport Automatically create backport pull requests when merged labels Nov 4, 2024
@DaveCTurner DaveCTurner merged commit a1daddc into elastic:main Nov 4, 2024
6 checks passed
@DaveCTurner DaveCTurner deleted the 2024/11/04/circuit-breakers-are-incomplete branch November 4, 2024 16:07
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Nov 4, 2024
The docs kinda imply that circuit breakers protect against OOMEs, at
least that's how some customers seem to interpret them. This commit adds
a note spelling out that this isn't the case.
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Nov 4, 2024
The docs kinda imply that circuit breakers protect against OOMEs, at
least that's how some customers seem to interpret them. This commit adds
a note spelling out that this isn't the case.
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Nov 4, 2024
The docs kinda imply that circuit breakers protect against OOMEs, at
least that's how some customers seem to interpret them. This commit adds
a note spelling out that this isn't the case.
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Nov 4, 2024
The docs kinda imply that circuit breakers protect against OOMEs, at
least that's how some customers seem to interpret them. This commit adds
a note spelling out that this isn't the case.
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
7.17
8.16
8.x
8.15

elasticsearchmachine pushed a commit that referenced this pull request Nov 4, 2024
The docs kinda imply that circuit breakers protect against OOMEs, at
least that's how some customers seem to interpret them. This commit adds
a note spelling out that this isn't the case.
elasticsearchmachine pushed a commit that referenced this pull request Nov 4, 2024
The docs kinda imply that circuit breakers protect against OOMEs, at
least that's how some customers seem to interpret them. This commit adds
a note spelling out that this isn't the case.
elasticsearchmachine pushed a commit that referenced this pull request Nov 4, 2024
The docs kinda imply that circuit breakers protect against OOMEs, at
least that's how some customers seem to interpret them. This commit adds
a note spelling out that this isn't the case.
elasticsearchmachine pushed a commit that referenced this pull request Nov 4, 2024
The docs kinda imply that circuit breakers protect against OOMEs, at
least that's how some customers seem to interpret them. This commit adds
a note spelling out that this isn't the case.
jozala pushed a commit that referenced this pull request Nov 13, 2024
The docs kinda imply that circuit breakers protect against OOMEs, at
least that's how some customers seem to interpret them. This commit adds
a note spelling out that this isn't the case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged :Core/Infra/Circuit Breakers Track estimates of memory consumption to prevent overload >docs General docs changes Team:Core/Infra Meta label for core/infra team Team:Docs Meta label for docs team v7.17.26 v8.15.5 v8.16.1 v8.17.0 v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants