-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Add a basic deprecation warning that the JSON format is changing in v9 #116330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pinging @elastic/es-core-infra (Team:Core/Infra) |
Hi @thecoop, I've created a changelog YAML for you. Note that since this PR is labelled |
LGTM except this is a deprecation so it needs a changelog entry - I adjusted the labels but you'll need to tweak the changelog it just added. |
@elasticmachine update branch |
The deprecation changelog will be added by #90529 |
The deprecation changelog needs to go into this PR so it gets backported to 8.x |
@elasticmachine update branch |
e828c71
to
0558887
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The deprecation changelog needs to go into this PR so it gets backported to 8.x
The deprecation changelog is in the manual backport PR, so that should be fine 👍
Have you checked if the failed Serverless check is related, it looks possible. But that shouldn't block this PR.
The serverless failure is an unrelated known issue |
…d errors is changing in v9 (elastic#116330)" This reverts commit bd091d3.
… is changing in v9 (elastic#116330)
… is changing in v9 (elastic#116330)
… is changing in v9 (elastic#116330)
V9 has a different non-detailed errors format, modified by #90529