Skip to content

Conversation

thecoop
Copy link
Member

@thecoop thecoop commented Nov 6, 2024

V9 has a different non-detailed errors format, modified by #90529

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@thecoop thecoop requested review from a team and DaveCTurner November 6, 2024 13:40
@thecoop thecoop added :Core/Infra/REST API REST infrastructure and utilities and removed :Core/Infra/Core Core issues without another label labels Nov 6, 2024
@elasticsearchmachine
Copy link
Collaborator

Hi @thecoop, I've created a changelog YAML for you. Note that since this PR is labelled >deprecation, you need to update the changelog YAML to fill out the extended information sections.

@DaveCTurner
Copy link
Contributor

LGTM except this is a deprecation so it needs a changelog entry - I adjusted the labels but you'll need to tweak the changelog it just added.

@thecoop
Copy link
Member Author

thecoop commented Nov 6, 2024

@elasticmachine update branch

@thecoop
Copy link
Member Author

thecoop commented Nov 6, 2024

The deprecation changelog will be added by #90529

@DaveCTurner
Copy link
Contributor

The deprecation changelog needs to go into this PR so it gets backported to 8.x

@thecoop
Copy link
Member Author

thecoop commented Nov 11, 2024

@elasticmachine update branch

@thecoop thecoop force-pushed the exception-json-warning-v9 branch from e828c71 to 0558887 Compare November 13, 2024 11:36
Copy link
Contributor

@mosche mosche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deprecation changelog needs to go into this PR so it gets backported to 8.x

The deprecation changelog is in the manual backport PR, so that should be fine 👍
Have you checked if the failed Serverless check is related, it looks possible. But that shouldn't block this PR.

https://gradle-enterprise.elastic.co/s/vrauj2k6yvf7m/tests/task/:qa:x-pack-rest-test:yamlRestTest/details/co.elastic.elasticsearch.qa.rest.ServerlessXpackRestIT/test%20%7Byaml%3Dprofiling%2F10_basic%2FTest%20flamegraph%20from%20profiling-events%7D?top-execution=1

@thecoop
Copy link
Member Author

thecoop commented Nov 13, 2024

The serverless failure is an unrelated known issue

@thecoop thecoop merged commit bd091d3 into elastic:main Nov 13, 2024
15 of 16 checks passed
@thecoop thecoop deleted the exception-json-warning-v9 branch November 13, 2024 14:17
thecoop added a commit that referenced this pull request Nov 13, 2024
thecoop added a commit to thecoop/elasticsearch that referenced this pull request Nov 13, 2024
smalyshev pushed a commit to smalyshev/elasticsearch that referenced this pull request Nov 13, 2024
afoucret pushed a commit to afoucret/elasticsearch that referenced this pull request Nov 14, 2024
alexey-ivanov-es pushed a commit to alexey-ivanov-es/elasticsearch that referenced this pull request Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Core/Infra/REST API REST infrastructure and utilities >non-issue Team:Core/Infra Meta label for core/infra team v8.17.0 v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants