-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Add tracking for query rule types #116357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tracking for query rule types #116357
Conversation
Hi @kderusso, I've created a changelog YAML for you. |
3b117bc
to
09b6eca
Compare
b4f66d4
to
aaeac5b
Compare
aaeac5b
to
14e925b
Compare
Pinging @elastic/search-eng (Team:SearchOrg) |
Pinging @elastic/search-relevance (Team:Search - Relevance) |
...rest/src/yamlRestTest/resources/rest-api-spec/test/entsearch/rules/20_query_ruleset_list.yml
Outdated
Show resolved
Hide resolved
setup: | ||
- requires: | ||
cluster_features: [ "gte_v8.10.0" ] | ||
reason: Introduced in 8.10.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this going to be an issue when we backport to 8.x? not saying we should necessarily change it here, but maybe when we backport we might need to?
buildkite test this |
💔 Backport failed
You can use sqren/backport to manually backport by running |
@ioanatia and @kderusso - I was able to get this merged - however, backporting this to the 8.16 and 8.15 branches are failing - and trying to run |
* Add total rule type counts to list calls and xpack usage * Add feature * Update docs/changelog/116357.yaml * Fix docs test failure & update yaml tests * remove additional spaces --------- Co-authored-by: Mark J. Hoy <[email protected]>
* Add total rule type counts to list calls and xpack usage * Add feature * Update docs/changelog/116357.yaml * Fix docs test failure & update yaml tests * remove additional spaces --------- Co-authored-by: Mark J. Hoy <[email protected]>
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
* Add total rule type counts to list calls and xpack usage * Add feature * Update docs/changelog/116357.yaml * Fix docs test failure & update yaml tests * remove additional spaces --------- Co-authored-by: Mark J. Hoy <[email protected]> (cherry picked from commit 1b03a96)
* Add total rule type counts to list calls and xpack usage * Add feature * Update docs/changelog/116357.yaml * Fix docs test failure & update yaml tests * remove additional spaces --------- Co-authored-by: Mark J. Hoy <[email protected]> (cherry picked from commit 1b03a96) Co-authored-by: Kathleen DeRusso <[email protected]>
* Add total rule type counts to list calls and xpack usage * Add feature * Update docs/changelog/116357.yaml * Fix docs test failure & update yaml tests * remove additional spaces --------- Co-authored-by: Mark J. Hoy <[email protected]>
This PR adds tracking for query rule types.
The List Query Rulesets PR has been updated to include total rule types. Here is an example updated response:
The
_xpack/usage
call also propagates these stats. Here is an example of the updatedenterprise_search
section: