-
Notifications
You must be signed in to change notification settings - Fork 25.6k
fixing examples #116369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing examples #116369
Conversation
Documentation preview: |
Pinging @elastic/es-docs (Team:Docs) |
Two things strike me here:
|
@leemthompo Agreed. We are only spot checking the top 20 articles. I added the comments to all examples, not just the untested examples, because I tested all of them. I am ok to not put the comments in and just review each of the 20 articles. That might be best. the plan is to automate this for all the rest. But wanted to fix the top 20 articles. |
Roger that @georgewallace! You can definitely assign a couple of these to writers too :) |
They are all under https://github.com/elastic/platform-docs-team/issues/527. Happy to assign some out, but know everyone is busy. |
@leemthompo I was thinking and I will just close this PR. After thinking about it, we can think about comment automation when testing examples or another way to do it, but for now it would only show on 20 of the pages across the repo which doesn't make sense. Thanks for the feedback. |
Validating samples across elasticsearch and marking samples as reviewed.