[Build] Remove mentioning ./gradlew assemble to build all distributions #116400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breskeby
added
>non-issue
:Delivery/Build
|
Documentation preview: |
|
Pinging @elastic/es-delivery (Team:Delivery) |
|
Related to this discussion in our forum: https://discuss.elastic.co/t/elasticsearch-build-failure/369889/5 |
We have suggested using `./gradlew assemble` in our README to build elasticsearch artifacts. This causes problems since this also includes building our wolfi image that is based on a non public available wolfi base image. To work around this we introduce a task `assemblePublicArtifacts` that we also reference in our docs for third party elasticsearch source user. This also reduces the stuff that is build beyond the distribution. like fixtures that are not part of the distribution.
breskeby
force-pushed
the
fix-external-assemble
branch
from
2baad8d to
ab211a8
Compare
mark-vieira
requested changes
Nov 7, 2024
build.gradle
Outdated
| * - building artifacts that are not required for a user (e.g. internally used test fixtures) | ||
| * - failure when building docker images with non public base images (e.g. wolfi) | ||
| * */ | ||
| tasks.register("assemblePublicArtifacts").configure { |
There was a problem hiding this comment.
I don't think there's value in such a task. There's no reason why anyone would want to build all these artifacts in one go and it just adds confusion. Let's omit this.
There was a problem hiding this comment.
removed that and removed mentioned of this and ./gradlew assemble from the README
breskeby
changed the title
mark-vieira
approved these changes
Nov 7, 2024
jozala
pushed a commit
that referenced
this pull request
Nov 13, 2024
…ns (#116400) This causes problems since this also includes building our wolfi image that is based on a non public available base image resulting in build failure for user without access to the docker registry. We should avoid suggesting using ./gradlew assemble as it builds a tons of stuff unrelated to any distribution. Instead people should be pointed to `./gradlew localDistro`
alexey-ivanov-es
pushed a commit
to alexey-ivanov-es/elasticsearch
that referenced
this pull request
Nov 28, 2024
…ns (elastic#116400) This causes problems since this also includes building our wolfi image that is based on a non public available base image resulting in build failure for user without access to the docker registry. We should avoid suggesting using ./gradlew assemble as it builds a tons of stuff unrelated to any distribution. Instead people should be pointed to `./gradlew localDistro`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes problems since this also includes building our wolfi image that is based on a non public available base image resulting in build failure for user without access to the docker registry.
We should avoid suggesting using ./gradlew assemble as it builds a tons of stuff unrelated to any distribution.
Instead people should be pointed to
./gradlew localDistro