Skip to content

Conversation

asmith-elastic
Copy link
Contributor

This request will add an additional description to the drop_null_columns query parameter which notes that the parameter requires the format to be set to yaml or json. If any other format is being used, null columns will still be shown.

Adding an additional description which notes that using the drop_null_columns parameter requires the format to be set to yaml or json. If these formats are not used, null columns will still be shown.
Copy link
Contributor

github-actions bot commented Nov 7, 2024

Documentation preview:

@elasticsearchmachine elasticsearchmachine added v9.0.0 needs:triage Requires assignment of a team area label labels Nov 7, 2024
@elasticsearchmachine
Copy link
Collaborator

@asmith-elastic please enable the option "Allow edits and access to secrets by maintainers" on your PR. For more information, see the documentation.

@elasticsearchmachine elasticsearchmachine added the external-contributor Pull request authored by a developer outside the Elasticsearch team label Nov 7, 2024
@nik9000 nik9000 added >docs General docs changes :Analytics/ES|QL AKA ESQL labels Nov 7, 2024
@elasticsearchmachine elasticsearchmachine added Team:Docs Meta label for docs team Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) and removed needs:triage Requires assignment of a team area label labels Nov 7, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@nik9000
Copy link
Member

nik9000 commented Nov 7, 2024

Sounds a bit like a bug to be honest. OTOH, for things like Arrow we can't know if the column is all the way null without getting all the output which is kind of a thing we'd like to avoid.

@nik9000
Copy link
Member

nik9000 commented Nov 8, 2024

What about cbor and smile?

@asmith-elastic
Copy link
Contributor Author

@nik9000 - Good catch! It does look like cbor and smile contains all_columns within the output, while (as you suspected) arrow does not. With this in mind, I'm going to make an update to this doc which notes the formats that are supported for both human readable and binary.

Given that this sounds like a bug, would you recommend I open up an associated issue to track if the other human readable options, such as csv, tsv, & txt has the same sort of limitations as arrow or if we are running into a bug?

Updating the wording to include CBOR, JSON, SMIL, and YAML formats.
@leemthompo
Copy link
Contributor

@nik9000 are you happy to merge this docs PR?

@leemthompo
Copy link
Contributor

Important

Elastic documentation is migrating to Markdown for version 9.0+. See the migration guide for details.

ℹ️ What's happening?

  • Starting January 29, we will start closing all unmerged documentation PRs targeting main/master
  • We're migrating from AsciiDoc to Markdown for 9.0+
  • 9.0 docs will be frozen from January 29 until February 20 2024
  • NOTE: PRs that include both code and documentation changes will remain open

What do I need to do?

For <=8.x docs:

  1. Rebase your PR to target the relevant 8.x branch instead
  2. The content can remain in AsciiDoc format

For 9.0+ docs:

Option 1:

  • Draft docs in Markdown
  • Once migration freeze ends, find the relevant page in the new docs system and use the edit options to submit your changes

Option 2:

💡 Need help?

  1. For Elasticians: Ask in #docs Slack channel
  2. For external contributors: Open an issue in elastic/docs-content

@nik9000
Copy link
Member

nik9000 commented Jan 29, 2025

Ah! We've fixed drop_null_columns to work in text response formats.

@nik9000 nik9000 closed this Jan 29, 2025
@nik9000 nik9000 removed the v9.0.0 label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/ES|QL AKA ESQL >docs General docs changes external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Docs Meta label for docs team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants