Skip to content

ES|QL: Fix funciton Telemetry tests #116470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 8, 2024
Merged

ES|QL: Fix funciton Telemetry tests #116470

merged 4 commits into from
Nov 8, 2024

Conversation

luigidellaquila
Copy link
Contributor

@luigidellaquila luigidellaquila commented Nov 8, 2024 •
edited
Loading

Wrong update of the number of snapshot functions from #115792

Fixes: #115231
Fixes: #116448
Fixes: #116462
Fixes: #116463
Fixes: #116464
Fixes: #116465

@luigidellaquila luigidellaquila added >test Issues or PRs that are addressing/adding tests auto-backport Automatically create backport pull requests when merged :Analytics/ES|QL AKA ESQL v8.17.0 labels Nov 8, 2024
@elasticsearchmachine elasticsearchmachine added Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v10.0.0 labels Nov 8, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@astefan astefan added the test-release Trigger CI checks against release build label Nov 8, 2024
@breskeby breskeby added v9.0.0 and removed v10.0.0 labels Nov 8, 2024
@luigidellaquila luigidellaquila mentioned this pull request Nov 8, 2024
Closed
ivancea
ivancea approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@ivancea ivancea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! How did this pass the CI, or why is this failing now?

@luigidellaquila
Copy link
Contributor Author

It only fails on release tests (ie. non-snapshot), the test is excluded in normal builds.
The final reason is that we see a different number of functions in Snapshot vs. non-Snapshot, so we need two tests that only run in specific configurations.
To see the failure on a PR, you have to label it test-release

@luigidellaquila luigidellaquila enabled auto-merge (squash) November 8, 2024 12:05
@luigidellaquila
Copy link
Contributor Author

KqlQueryBuilderTests failing, completely unrelated

@luigidellaquila
Copy link
Contributor Author

@elasticmachine update branch

@luigidellaquila
Copy link
Contributor Author

@elasticmachine update branch

@luigidellaquila luigidellaquila merged commit 6ab260c into elastic:main Nov 8, 2024
17 checks passed
@luigidellaquila luigidellaquila mentioned this pull request Nov 11, 2024
Closed
luigidellaquila added a commit to luigidellaquila/elasticsearch that referenced this pull request Nov 11, 2024
@luigidellaquila
ES|QL: Fix funciton Telemetry tests (elastic#116470)
53092d4
@luigidellaquila luigidellaquila mentioned this pull request Nov 11, 2024
Merged
elasticsearchmachine pushed a commit that referenced this pull request Nov 12, 2024
@luigidellaquila @elasticmachine
ES|QL: Fix funciton Telemetry tests (#116470) (#116580)
9a60142 
Co-authored-by: Elastic Machine <[email protected]>
jozala pushed a commit that referenced this pull request Nov 13, 2024
@luigidellaquila @jozala
ES|QL: Fix funciton Telemetry tests (#116470)
afcb513
afoucret pushed a commit to afoucret/elasticsearch that referenced this pull request Nov 14, 2024
@luigidellaquila @afoucret
ES|QL: Fix funciton Telemetry tests (elastic#116470)
6a991e5
alexey-ivanov-es pushed a commit to alexey-ivanov-es/elasticsearch that referenced this pull request Nov 28, 2024
@luigidellaquila @alexey-ivanov-es
ES|QL: Fix funciton Telemetry tests (elastic#116470)
7be9006
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ivancea ivancea ivancea approved these changes

Assignees

No one assigned

Labels

:Analytics/ES|QL AKA ESQL auto-backport Automatically create backport pull requests when merged Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests test-release Trigger CI checks against release build v8.17.0 v9.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CI] EsqlClientYamlIT test {p0=esql/60_usage/Basic ESQL usage output (telemetry) non-snapshot version} failing [CI] EsqlClientYamlAsyncSubmitAndFetchIT test {p0=esql/60_usage/Basic ESQL usage output (telemetry) non-snapshot version} failing [CI] EsqlClientYamlAsyncIT test {p0=esql/60_usage/Basic ESQL usage output (telemetry) non-snapshot version} failing [CI] XPackRestIT test {p0=esql/60_usage/Basic ESQL usage output (telemetry) non-snapshot version} failing [CI] XPackRestIT test {p0=esql/60_usage/Basic ESQL usage output (telemetry)} failing
[CI] EsqlClientYamlIT test {p0=esql/60_usage/Basic ESQL usage output (telemetry) non-snapshot version} failing

6 participants

@luigidellaquila @elasticsearchmachine @ivancea @breskeby @astefan @elasticmachine