Skip to content

Conversation

georgewallace
Copy link
Contributor

Copy link
Contributor

github-actions bot commented Nov 8, 2024

Documentation preview:

@georgewallace georgewallace added >docs General docs changes Team:Docs Meta label for docs team labels Nov 8, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@linyaru
Copy link

linyaru commented Nov 8, 2024

  • I think we should modify the header of the first example section to be "ELSER service example"
Screenshot 2024-11-08 at 3 30 06 PM
  • "The following example shows how to create an inference endpoint called my-elser-model to perform a sparse_embedding task type and configure adaptive allocations." could become "The following example shows how to create an inference endpoint called my-elser-model to perform a sparse_embedding task type and configure adaptive allocations (recommended)."
  • The next section header could be "Creating ELSER service without adaptive allocations"
Screenshot 2024-11-08 at 3 34 01 PM
  • "The following example shows how to create an inference endpoint called my-elser-model to perform a sparse_embedding task type." could become "The following example shows how to create an inference endpoint called my-elser-model to perform a sparse_embedding task type when adaptive allocations isn't required or trained model autoscaling isn't available."

@georgewallace
Copy link
Contributor Author

@linyaru made the changes as you suggested. Please take another look and let me know.

@linyaru
Copy link

linyaru commented Nov 26, 2024

Sorry for missing this, LGTM!

@leemthompo leemthompo added auto-backport Automatically create backport pull requests when merged v8.16.0 v8.17.0 v8.18.0 labels Nov 27, 2024
@leemthompo leemthompo merged commit 9e61089 into main Nov 27, 2024
6 checks passed
@leemthompo leemthompo deleted the georgewallace-patch-5 branch November 27, 2024 10:39
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.16
8.17
8.x

georgewallace added a commit to georgewallace/elasticsearch that referenced this pull request Nov 27, 2024
georgewallace added a commit to georgewallace/elasticsearch that referenced this pull request Nov 27, 2024
georgewallace added a commit to georgewallace/elasticsearch that referenced this pull request Nov 27, 2024
elasticsearchmachine pushed a commit that referenced this pull request Nov 27, 2024
elasticsearchmachine pushed a commit that referenced this pull request Nov 27, 2024
elasticsearchmachine pushed a commit that referenced this pull request Nov 27, 2024
cbuescher pushed a commit to cbuescher/elasticsearch that referenced this pull request Nov 27, 2024
alexey-ivanov-es pushed a commit to alexey-ivanov-es/elasticsearch that referenced this pull request Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged >docs General docs changes Team:Docs Meta label for docs team v8.16.0 v8.17.0 v8.18.0 v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants