Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/changelog/116541.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
pr: 116541
summary: Update `index.max_result_window` error to point to `search_after` not scroll
area: Search
type: enhancement
issues: []
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ setup:
---
"Request window limits without scroll":
- do:
catch: /Result window is too large, from \+ size must be less than or equal to[:] \[10000\] but was \[10010\]\. See the scroll api for a more efficient way to request large data sets\./
catch: /Result window is too large, from \+ size must be less than or equal to[:] \[10000\] but was \[10010\]\. See search after for a more efficient way to request large data sets\./
search:
rest_total_hits_as_int: true
index: test_1
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -571,7 +571,7 @@ private void assertWindowFails(SearchRequestBuilder search) {
+ IndexSettings.MAX_RESULT_WINDOW_SETTING.get(Settings.EMPTY)
)
);
assertThat(e.toString(), containsString("See the scroll api for a more efficient way to request large data sets"));
assertThat(e.toString(), containsString("See search after for a more efficient way to request large data sets"));
}

private void assertRescoreWindowFails(int windowSize) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,7 @@ public void preProcess() {
+ maxResultWindow
+ "] but was ["
+ resultWindow
+ "]. See the scroll api for a more efficient way to request large data sets. "
+ "]. See search after for a more efficient way to request large data sets. "
+ "This limit can be set by changing the ["
+ IndexSettings.MAX_RESULT_WINDOW_SETTING.getKey()
+ "] index level setting."
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ protected Engine.Searcher acquireSearcherInternal(String source) {
"Result window is too large, from + size must be less than or equal to:"
+ " ["
+ maxResultWindow
+ "] but was [310]. See the scroll api for a more efficient way to request large data sets. "
+ "] but was [310]. See search after for a more efficient way to request large data sets. "
+ "This limit can be set by changing the ["
+ IndexSettings.MAX_RESULT_WINDOW_SETTING.getKey()
+ "] index level setting."
Expand Down