Skip to content

[DOCS] Update sharepoint-online connector perms #116641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 12, 2024
Merged

[DOCS] Update sharepoint-online connector perms #116641

merged 3 commits into from
Nov 12, 2024

Conversation

leemthompo
Copy link
Contributor

@leemthompo leemthompo added >docs General docs changes Team:Docs Meta label for docs team auto-backport Automatically create backport pull requests when merged v8.16.0 v8.17.0 labels Nov 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

Documentation preview:

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

leemthompo
leemthompo commented Nov 12, 2024
View reviewed changes
@leemthompo leemthompo self-assigned this Nov 12, 2024
@leemthompo leemthompo requested a review from jedrazb November 12, 2024 11:22
seanstory
seanstory approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@seanstory seanstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this, do we need to cover any extra steps to tell the customer how to "select" which sites should be covered in this scope?

@leemthompo leemthompo merged commit a71c132 into main Nov 12, 2024
6 checks passed
@leemthompo leemthompo deleted the leemthompo-patch-perms branch November 12, 2024 15:14
@leemthompo
Copy link
Contributor Author

With this, do we need to cover any extra steps to tell the customer how to "select" which sites should be covered in this scope?

Merged to get the change in ASAP, but let me know your thoughts on this.

javanna pushed a commit to javanna/elasticsearch that referenced this pull request Nov 12, 2024
@leemthompo @javanna
[DOCS] Update sharepoint-online connector perms (elastic#116641)
2a6b02b
@seanstory
Copy link
Member

😱 it's even worse than I'd thought. I figured that when you choose "sites.selected" in their UI, you'd then get some dropdown where you could multi-select sites to have it apply to.
Nope. Have to use powershell or the graph API to specifically grant the new application ID access to specific sites. See: https://blog.dan-toft.dk/2022/12/sites-selected-permissions/

@seanstory
Copy link
Member

So we're going to need docs similar to what we have here: https://www.elastic.co/guide/en/elasticsearch/reference/8.16/es-connectors-sharepoint-online.html#es-connectors-sharepoint-online-oauth-app-permissions but to cover how to work with Sites.selected.

Of course Crest failed to mention any of this 💀

jozala pushed a commit that referenced this pull request Nov 13, 2024
@leemthompo @jozala
[DOCS] Update sharepoint-online connector perms (#116641)
b25d116
afoucret pushed a commit to afoucret/elasticsearch that referenced this pull request Nov 14, 2024
@leemthompo @afoucret
[DOCS] Update sharepoint-online connector perms (elastic#116641)
9f5efb9
@leemthompo leemthompo mentioned this pull request Nov 27, 2024
Merged
@leemthompo
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
✅ 8.17
✅ 8.16

Questions ?

Please refer to the Backport tool documentation

@leemthompo leemthompo mentioned this pull request Nov 27, 2024
Merged
leemthompo added a commit to leemthompo/elasticsearch that referenced this pull request Nov 27, 2024
@leemthompo
[DOCS] Update sharepoint-online connector perms (elastic#116641)
3727307 
(cherry picked from commit a71c132)
leemthompo added a commit to leemthompo/elasticsearch that referenced this pull request Nov 27, 2024
@leemthompo
[DOCS] Update sharepoint-online connector perms (elastic#116641)
e88ae54 
(cherry picked from commit a71c132)
@leemthompo leemthompo mentioned this pull request Nov 27, 2024
Merged
@leemthompo
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
✅ 8.x

Questions ?

Please refer to the Backport tool documentation

leemthompo added a commit to leemthompo/elasticsearch that referenced this pull request Nov 27, 2024
@leemthompo
[DOCS] Update sharepoint-online connector perms (elastic#116641)
2014e02 
(cherry picked from commit a71c132)
elasticsearchmachine pushed a commit that referenced this pull request Nov 27, 2024
@leemthompo
[DOCS] Update sharepoint-online connector perms (#116641) (#117633)
64c0d25 
(cherry picked from commit a71c132)
elasticsearchmachine pushed a commit that referenced this pull request Nov 27, 2024
@leemthompo
[DOCS] Update sharepoint-online connector perms (#116641) (#117635)
7652e12 
(cherry picked from commit a71c132)
elasticsearchmachine pushed a commit that referenced this pull request Nov 27, 2024
@leemthompo
[DOCS] Update sharepoint-online connector perms (#116641) (#117634)
70a58d5 
(cherry picked from commit a71c132)
@leemthompo leemthompo mentioned this pull request Nov 27, 2024
Closed
alexey-ivanov-es pushed a commit to alexey-ivanov-es/elasticsearch that referenced this pull request Nov 28, 2024
@leemthompo @alexey-ivanov-es
[DOCS] Update sharepoint-online connector perms (elastic#116641)
bb416ce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanstory seanstory seanstory approved these changes

@jedrazb jedrazb Awaiting requested review from jedrazb

Assignees

@leemthompo leemthompo

Labels

auto-backport Automatically create backport pull requests when merged >docs General docs changes Team:Docs Meta label for docs team v8.16.0 v8.17.0 v8.18.0 v9.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@leemthompo @elasticsearchmachine @seanstory