Skip to content

Fix NPE in MlMemoryAutoscalingDecider #116650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 12, 2024
Merged

Fix NPE in MlMemoryAutoscalingDecider #116650

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4b0221d
Fix NPE in MlMemoryAutoscalingDecider
jan-elastic Nov 12, 2024
c3ced9b
Update docs/changelog/116650.yaml
jan-elastic Nov 12, 2024
25fc5fc
Update 116650.yaml
jan-elastic Nov 12, 2024
263744a
Update docs/changelog/116650.yaml
jan-elastic Nov 12, 2024
973ab5f
better fix
jan-elastic Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/changelog/116650.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
pr: 116650
summary: Fix NPE in `MlMemoryAutoscalingDecider`
area: Machine Learning
type: bug
issues: []
2 changes: 1 addition & 1 deletion ...n/ml/src/main/java/org/elasticsearch/xpack/ml/autoscaling/MlMemoryAutoscalingDecider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ public MlMemoryAutoscalingCapacity scale(
.map(result -> {
MlMemoryAutoscalingCapacity capacity = ensureScaleDown(
result,
MlMemoryAutoscalingCapacity.from(context.currentCapacity()).build()
context.currentCapacity() == null ? null : MlMemoryAutoscalingCapacity.from(context.currentCapacity()).build()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • context.currentCapacity() can be null, see JavaDoc.
  • MlMemoryAutoscalingCapacity.from(null) gives null pointer exception
  • ensureScaleDown(..., null) = null

);
if (capacity == null) {
return null;
Expand Down
Loading