Introduce Email Address Allow Lists For Watcher #116672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukewhiting
added
>enhancement
>docs
|
Documentation preview: |
|
Pinging @elastic/es-docs (Team:Docs) |
elasticsearchmachine
added
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
lukewhiting
force-pushed
the
email-address-pattern-allow
branch
from
3bdf71e to
7292283
Compare
dakrone
approved these changes
Nov 13, 2024
...n/watcher/src/main/java/org/elasticsearch/xpack/watcher/notification/email/EmailService.java
Outdated
Show resolved
Hide resolved
Fix comment
lukewhiting
added
the
auto-backport
…dress-pattern-allow
💚 Backport successful
|
lukewhiting
added a commit
to lukewhiting/elasticsearch
that referenced
this pull request
Nov 14, 2024
* New setting plus mutual exclusiveness validation * New domain list checking * Email service tests * Documentation updates * PR Changes Fix comment
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 14, 2024
) * Introduce Email Address Allow Lists For Watcher (#116672) * New setting plus mutual exclusiveness validation * New domain list checking * Email service tests * Documentation updates * PR Changes Fix comment * Backport missing Settings method for default value with validator
salvatore-campagna
pushed a commit
to salvatore-campagna/elasticsearch
that referenced
this pull request
Nov 18, 2024
* New setting plus mutual exclusiveness validation * New domain list checking * Email service tests * Documentation updates * PR Changes Fix comment
alexey-ivanov-es
pushed a commit
to alexey-ivanov-es/elasticsearch
that referenced
this pull request
Nov 28, 2024
* New setting plus mutual exclusiveness validation * New domain list checking * Email service tests * Documentation updates * PR Changes Fix comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new setting for Watcher that allows you to restrict sending of emails to addresses matching a specific pattern.
For example, if
xpack.notification.email.recipient_allowlistis set to['*[email protected]', '*@mydomain.com']then Watcher emails sent via To, CC or BCC to the following addresses would be allowed:But any e-mail with a recipient in this list would be blocked:
This new setting is mutually exclusive with the existing domain based allow list setting
xpack.notification.email.account.domain_allowlistand will throw an error if both are set to a non default value.