Skip to content

Conversation

GalLalouche
Copy link
Contributor

Backporting #116591 since I forgot to turn on the auto-backport label.

Copy link
Contributor

Documentation preview:

@elasticsearchmachine elasticsearchmachine added v8.17.0 Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) labels Nov 13, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine
Copy link
Collaborator

Hi @GalLalouche, I've created a changelog YAML for you.

@GalLalouche GalLalouche force-pushed the feature/bytelength_8.x branch from 249c265 to ff96e7f Compare November 13, 2024 14:25
Copy link
Contributor

@craigtaverner craigtaverner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just fix the duplicated changelog.

@GalLalouche GalLalouche force-pushed the feature/bytelength_8.x branch from ff96e7f to 2400389 Compare November 14, 2024 11:16
Copy link
Contributor

@craigtaverner craigtaverner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm surprised github actions did not recreate the new changelog. Hopefully it stays that way.

@GalLalouche GalLalouche enabled auto-merge (squash) November 14, 2024 11:43
@GalLalouche GalLalouche changed the title [ES|QL] Add support BYTE_LENGTH scalar function (#116591) [ES|QL] [8.x] Add support BYTE_LENGTH scalar function (#116591) Nov 14, 2024
@GalLalouche GalLalouche changed the title [ES|QL] [8.x] Add support BYTE_LENGTH scalar function (#116591) [8.x] [ES|QL] Add support BYTE_LENGTH scalar function (#116591) Nov 14, 2024
@GalLalouche GalLalouche added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Nov 14, 2024
@GalLalouche GalLalouche disabled auto-merge November 14, 2024 12:09
@GalLalouche GalLalouche removed the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Nov 14, 2024
@GalLalouche GalLalouche enabled auto-merge (squash) November 14, 2024 12:09
@GalLalouche GalLalouche merged commit dae79b5 into elastic:8.x Nov 14, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/ES|QL AKA ESQL backport >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.17.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants