Skip to content

Mention bbq_hnsw for m and ef_construction options #117022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 25, 2024
Merged

Mention bbq_hnsw for m and ef_construction options #117022

merged 2 commits into from
Nov 25, 2024

Conversation

Philippus
Copy link
Contributor

@Philippus Philippus commented Nov 19, 2024 •
edited
Loading

Applying this PR will mention bbq_hnsw for the m and ef_construction options. See

elasticsearch/server/src/main/java/org/elasticsearch/index/mapper/vectors/DenseVectorFieldMapper.java

Line 1384 in ea90fbc

return new BBQHnswIndexOptions(m, efConstruction);
.

@github-actions GitHub Actions
Copy link
Contributor

Documentation preview:

@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label v9.0.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Nov 19, 2024
@AI-IshanBhatt AI-IshanBhatt added the :Search Relevance/Search Catch all for Search Relevance label Nov 20, 2024
@elasticsearchmachine elasticsearchmachine added Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch and removed needs:triage Requires assignment of a team area label labels Nov 20, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

carlosdelest
carlosdelest approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@carlosdelest carlosdelest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@carlosdelest carlosdelest added the >docs General docs changes label Nov 25, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Docs Meta label for docs team label Nov 25, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@leemthompo
Copy link
Contributor

@elasticmachine test this

@leemthompo
Copy link
Contributor

run docs-build

@carlosdelest carlosdelest added auto-backport Automatically create backport pull requests when merged v8.17.0 v8.18.0 labels Nov 25, 2024
@carlosdelest carlosdelest merged commit fd6e885 into elastic:main Nov 25, 2024
7 checks passed
@carlosdelest
Copy link
Member

Thanks for your contribution, @Philippus !

This was referenced Nov 25, 2024
Merged
Merged
carlosdelest pushed a commit to carlosdelest/elasticsearch that referenced this pull request Nov 25, 2024
@Philippus @carlosdelest
Mention bbq_hnsw for m and ef_construction options in docs (ela…
504c4f0 
…stic#117022)
carlosdelest pushed a commit to carlosdelest/elasticsearch that referenced this pull request Nov 25, 2024
@Philippus @carlosdelest
Mention bbq_hnsw for m and ef_construction options in docs (ela…
5fb0a59 
…stic#117022)
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 8.17
✅ 8.x

elasticsearchmachine pushed a commit that referenced this pull request Nov 25, 2024
@carlosdelest @Philippus
Mention bbq_hnsw for m and ef_construction options in docs (#11…
b5c8e38 
…7022) (#117480)

Co-authored-by: Philippus Baalman <[email protected]>
elasticsearchmachine pushed a commit that referenced this pull request Nov 25, 2024
@carlosdelest @Philippus
Mention bbq_hnsw for m and ef_construction options in docs (#11…
dbb1bc2 
…7022) (#117481)

Co-authored-by: Philippus Baalman <[email protected]>
@Philippus Philippus deleted the add-bbw-hnsw-to-m-and-ef-construction-options branch November 25, 2024 14:55
alexey-ivanov-es pushed a commit to alexey-ivanov-es/elasticsearch that referenced this pull request Nov 28, 2024
@Philippus @alexey-ivanov-es
Mention bbq_hnsw for m and ef_construction options in docs (ela…
2004b1f 
…stic#117022)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carlosdelest carlosdelest carlosdelest approved these changes

Assignees

@carlosdelest carlosdelest

Labels

auto-backport Automatically create backport pull requests when merged >docs General docs changes external-contributor Pull request authored by a developer outside the Elasticsearch team :Search Relevance/Search Catch all for Search Relevance Team:Docs Meta label for docs team Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v8.17.0 v8.18.0 v9.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Philippus @elasticsearchmachine @leemthompo @carlosdelest @AI-IshanBhatt