Skip to content

Conversation

h3xcat
Copy link

@h3xcat h3xcat commented Nov 20, 2024

A simple fix for #98115

Instead of trying to pass the secret value through stdin, this uses elasticsearch-keystore add-file with process substitution.

@h3xcat h3xcat requested a review from a team as a code owner November 20, 2024 19:04
@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label v9.0.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Nov 20, 2024
@mark-vieira mark-vieira added :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts :Core/Infra/CLI CLI utilities, scripts, and infrastructure >bug labels Nov 20, 2024
@elasticsearchmachine elasticsearchmachine added Team:Core/Infra Meta label for core/infra team Team:Delivery Meta label for Delivery team and removed needs:triage Requires assignment of a team area label labels Nov 20, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@h3xcat
Copy link
Author

h3xcat commented Dec 5, 2024

Would it be feasible to have this implemented in upcoming releases?

@rjernst rjernst self-assigned this Dec 6, 2024
breskeby
breskeby previously approved these changes Feb 21, 2025
@breskeby breskeby dismissed their stale review April 6, 2025 17:38

This is breaking existing behavior. Accidentally approving before.

@breskeby
Copy link
Contributor

breskeby commented Apr 6, 2025

Leaving this to @rjernst as he selfassigned this one

@rjernst
Copy link
Member

rjernst commented Apr 11, 2025

Thanks for the change @h3xcat. We've decided to go a different route to address #98115, see #126729.

@rjernst rjernst closed this Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>bug :Core/Infra/CLI CLI utilities, scripts, and infrastructure :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Core/Infra Meta label for core/infra team Team:Delivery Meta label for Delivery team v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants