Handle semantic text partial updates when the field is in an object #117272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ield is in an object
Mikep86
added
>bug
:SearchOrg/Relevance
|
Hi @Mikep86, I've created a changelog YAML for you. |
Mikep86
commented
Nov 21, 2024
...rc/yamlRestTest/resources/rest-api-spec/test/inference/60_semantic_text_inference_update.yml
Outdated
Show resolved
Hide resolved
Mikep86
commented
Nov 21, 2024
Comment on lines
+493
to
+516
| - do: | ||
| update: | ||
| index: test-in-object-index | ||
| id: doc_1 | ||
| body: | ||
| doc: { "object.sparse_source_field": "sparse data 3", "object.dense_source_field": "dense data 3" } | ||
|
|
||
| - do: | ||
| get: | ||
| index: test-in-object-index | ||
| id: doc_1 | ||
|
|
||
| - match: { _source.object.sparse_field.text: "sparse data 1" } | ||
| - length: { _source.object.sparse_field.inference.chunks: 3 } | ||
| - match: { _source.object.sparse_field.inference.chunks.1.text: "sparse data 2" } | ||
| - exists: _source.object.sparse_field.inference.chunks.1.embeddings | ||
| - match: { _source.object.sparse_field.inference.chunks.2.text: "sparse data 3" } | ||
| - exists: _source.object.sparse_field.inference.chunks.2.embeddings | ||
| - match: { _source.object.dense_field.text: "dense data 1" } | ||
| - length: { _source.object.dense_field.inference.chunks: 3 } | ||
| - match: { _source.object.dense_field.inference.chunks.1.text: "dense data 2" } | ||
| - exists: _source.object.dense_field.inference.chunks.1.embeddings | ||
| - match: { _source.object.dense_field.inference.chunks.2.text: "dense data 3" } | ||
| - exists: _source.object.dense_field.inference.chunks.2.embeddings |
There was a problem hiding this comment.
Notice how the updated values for object.sparse_source_field and object.dense_source_field are appended instead of overwritten. This is because they are defined using a flat path instead of a nested path, resulting in a merged _source with both values:
{
"object": {
"sparse_source_field": "sparse data 2",
"dense_source_field": "dense data 2",
},
"object.sparse_source_field": "sparse data 3",
"object.dense_source_field": "dense data 3"
}
Mikep86
added
the
auto-backport
|
Pinging @elastic/search-eng (Team:SearchOrg) |
|
Pinging @elastic/search-relevance (Team:Search - Relevance) |
|
Hi @Mikep86, I've updated the changelog YAML for you. |
elasticsearchmachine
added
v8.19.0
v9.1.0
v8.16.5
and removed
v8.18.0
v9.0.0
v8.16.4
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #117258