Skip to content

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Nov 21, 2024

Relates to #115375

This PR comments out a link that was causing the following build error:

INFO:build_docs:asciidoctor: WARNING: invalid reference: transient-settings-migration-guide

If the content in transient-settings-migration-guide.asciidoc is still necessary, it will need to be mentioned in an include statement from some other file to pull it into the build. In 8.x it was included here:

include::transient-settings-migration-guide.asciidoc[]

@lcawl lcawl added >docs General docs changes Team:Docs Meta label for docs team labels Nov 21, 2024
Copy link
Contributor

Documentation preview:

@lcawl lcawl added the v9.0.0 label Nov 21, 2024
@lcawl lcawl requested a review from a team November 21, 2024 21:37
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending clean ci

Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀
Thanks for fixing!

@lcawl lcawl enabled auto-merge (squash) November 21, 2024 21:41
@lcawl lcawl disabled auto-merge November 21, 2024 21:54
@lcawl lcawl merged commit 8fe8d22 into elastic:main Nov 21, 2024
6 checks passed
@lcawl lcawl deleted the migration-link branch November 21, 2024 22:02
smalyshev pushed a commit to smalyshev/elasticsearch that referenced this pull request Nov 22, 2024
alexey-ivanov-es pushed a commit to alexey-ivanov-es/elasticsearch that referenced this pull request Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>docs General docs changes Team:Docs Meta label for docs team v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants