ES|QL: fix validation of SORT by aggregate functions #117316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luigidellaquila
added
>bug
auto-backport
|
Documentation preview: |
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
|
Hi @luigidellaquila, I've created a changelog YAML for you. |
alex-spies
approved these changes
Nov 22, 2024
x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/analysis/Verifier.java
Outdated
Show resolved
Hide resolved
luigidellaquila
added a commit
to luigidellaquila/elasticsearch
that referenced
this pull request
Nov 22, 2024
💔 Backport failed
You can use sqren/backport to manually backport by running |
luigidellaquila
added a commit
to luigidellaquila/elasticsearch
that referenced
this pull request
Nov 22, 2024
luigidellaquila
added a commit
to luigidellaquila/elasticsearch
that referenced
this pull request
Nov 22, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 22, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 22, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 22, 2024
smalyshev
pushed a commit
to smalyshev/elasticsearch
that referenced
this pull request
Nov 22, 2024
alexey-ivanov-es
pushed a commit
to alexey-ivanov-es/elasticsearch
that referenced
this pull request
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SORT <expression>is translated toEVAL x = <expression> | SORT x.If the expression contains aggregate functions, it should fail validation (and now it does).
Fixes: #117314