-
Notifications
You must be signed in to change notification settings - Fork 25.6k
ESQL: Expand type compatibility for match function and operator #117555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
carlosdelest
merged 44 commits into
elastic:main
from
carlosdelest:non-issue/esql-match-type-compat
Dec 9, 2024
Merged
Changes from 12 commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
34c7cbb
Add support for match types in match function
carlosdelest e260d68
Add tests
carlosdelest 0395751
Use queryAsObject() instead of queryAsString() to provide match query…
carlosdelest f901033
Changed function signature docs
carlosdelest b4c8c52
Add CSV tests for types
carlosdelest ca600bb
Add match operator CSV tests
carlosdelest 2a1d6f2
Merge branch 'main' into non-issue/esql-match-type-compat
carlosdelest 35193e3
Fix merge
carlosdelest f1e7ec0
Spotless
carlosdelest 005d3b3
Fix merge
carlosdelest caba4ba
Fix tests
carlosdelest bd846b9
Add types to match operator tests and docs
carlosdelest f2ba267
Fix non-integer field test
carlosdelest 5f0f502
Remove compatibility test that no longer works
carlosdelest 33c069e
Add new capability for BwC tests
carlosdelest 7561f58
Fix forbidden API
carlosdelest 96583d7
Add capability to tests
carlosdelest 22dcdb4
Fix tests
carlosdelest 8bc990d
Validate parameters compatibility in match
carlosdelest a845b5a
Add tests for multiple parameter types and checks validation
carlosdelest 8dca0e2
Add casting support for match operator
carlosdelest 9382ab8
Add tests for pushing down filters on different variants (casting, st…
carlosdelest 8e00824
Better handling of random values generation
carlosdelest bdd8638
Conversions for casting to date types
carlosdelest c62c24d
Fix CSV tests
carlosdelest cc9f248
Add tests for numeric conversion
carlosdelest 01d0234
Update docs
carlosdelest d9bc4ce
Merge branch 'main' into non-issue/esql-match-type-compat
carlosdelest 0678ff4
Fix merge
carlosdelest 8a7fc4d
Fix test
carlosdelest 8c6065b
Update tests for string parameters
carlosdelest 97a6503
Add documentation
carlosdelest cf3f705
Update docs/changelog/117555.yaml
carlosdelest 8102163
Fix changelog
carlosdelest edf9838
Fix tests ignoring order
carlosdelest 347b3ce
Adding support for casting on the field type and allowing multi-index…
carlosdelest b182a87
Additional tests and checks for using multi index fields with differe…
carlosdelest d8f5e0b
Merge branch 'main' into non-issue/esql-match-type-compat
carlosdelest fa14ff5
Fixed tests to include new field type
carlosdelest 9060cba
Use lenient match queries to allow mixed data fields with wrong value…
carlosdelest e723ae6
Remove casting on match query side
carlosdelest 0e6e7a1
Merge branch 'main' into non-issue/esql-match-type-compat
carlosdelest b0ac5f1
Fix merge
carlosdelest 71e78f9
Spotless
carlosdelest File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
2,112 changes: 2,109 additions & 3 deletions
2,112
docs/reference/esql/functions/kibana/definition/match.json
Large diffs are not rendered by default.
Oops, something went wrong.
2,112 changes: 2,109 additions & 3 deletions
2,112
docs/reference/esql/functions/kibana/definition/match_operator.json
Large diffs are not rendered by default.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
117 changes: 117 additions & 0 deletions
117
docs/reference/esql/functions/types/match_operator.asciidoc
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to this change, but useful to pinpoint an error in a CSV test