ESQL: Remove obsolete code path for aggs #117833
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essentially a forward-port of #117832
Since #104958,
AggregateExeccannot have aliases in itsaggregates- because any such aliases are turned intoEvals.But before that, a
STATScommand likewould result in an
AggregateExeclikewhere the renaming
languages{f}#5 AS lis pushed into the aggregates and the groupings refer to it via the reference attribute[l{r}#1].AbstractPhysicalOperationProviders.groupingPhysicalOperationstill addresses this remnant of times long past by checking whetherAggregateExechas anyAliases in itsaggregates, and adjusting the aggregation'slayoutso it points to the source attributelanguages{f}#5, not the renamed attributel{r}#1(because the renamed attribute is not present in the source layout!)Let's get rid of this dead code since it is confusing.