Skip to content

Conversation

alexey-ivanov-es
Copy link
Contributor

@alexey-ivanov-es alexey-ivanov-es commented Dec 4, 2024

Removes all occurrences of UpdateForV9 annotation owned by Core/Infra that are not blocked

*/
@UpdateForV9(owner = UpdateForV9.Owner.CORE_INFRA) // introduce IndexSettingDeprecatedInV8AndRemovedInV9 to replace this constant
IndexSettingDeprecatedInV7AndRemovedInV8,
IndexSettingDeprecatedInV8AndRemovedInV9,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need it?

FIXED("fixed"),
@Deprecated(forRemoval = true)
@UpdateForV9(owner = UpdateForV9.Owner.CORE_INFRA) // no longer used, remove in v9
FIXED_AUTO_QUEUE_SIZE("fixed_auto_queue_size"),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR for 8.x: #118492

return previousNodeVersion;
}
return "7.17.0";
return BuildVersion.fromVersionId(Version.CURRENT.minimumCompatibilityVersion().id);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it ok to use Version here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not ideal. Maybe we need a BuildVersion.getMinimumCompatible method to calculate this without invoking Version. @ryan what do you think?

@alexey-ivanov-es alexey-ivanov-es added :Core/Infra/Core Core issues without another label >refactoring labels Dec 12, 2024
@alexey-ivanov-es alexey-ivanov-es marked this pull request as ready for review December 12, 2024 17:20
@alexey-ivanov-es alexey-ivanov-es requested a review from a team as a code owner December 12, 2024 17:20
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Dec 12, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@alexey-ivanov-es alexey-ivanov-es requested a review from a team as a code owner December 12, 2024 20:46
@alexey-ivanov-es
Copy link
Contributor Author

PR split to:
#119088
#119095
#119101
#119105

@alexey-ivanov-es alexey-ivanov-es deleted the ES-9378 branch March 7, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Core/Infra/Core Core issues without another label >refactoring Team:Core/Infra Meta label for core/infra team v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants