-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Address and remove all occurrences of the Java annotation @UpdateForV9 (ES-9378) #117992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
*/ | ||
@UpdateForV9(owner = UpdateForV9.Owner.CORE_INFRA) // introduce IndexSettingDeprecatedInV8AndRemovedInV9 to replace this constant | ||
IndexSettingDeprecatedInV7AndRemovedInV8, | ||
IndexSettingDeprecatedInV8AndRemovedInV9, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need it?
FIXED("fixed"), | ||
@Deprecated(forRemoval = true) | ||
@UpdateForV9(owner = UpdateForV9.Owner.CORE_INFRA) // no longer used, remove in v9 | ||
FIXED_AUTO_QUEUE_SIZE("fixed_auto_queue_size"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR for 8.x: #118492
return previousNodeVersion; | ||
} | ||
return "7.17.0"; | ||
return BuildVersion.fromVersionId(Version.CURRENT.minimumCompatibilityVersion().id); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it ok to use Version
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not ideal. Maybe we need a BuildVersion.getMinimumCompatible
method to calculate this without invoking Version
. @ryan what do you think?
Pinging @elastic/es-core-infra (Team:Core/Infra) |
server/src/main/java/org/elasticsearch/index/IndexVersions.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/env/NodeMetadataTests.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/env/NodeMetadataTests.java
Outdated
Show resolved
Hide resolved
test/framework/src/main/java/org/elasticsearch/test/junit/listeners/ReproduceInfoPrinter.java
Show resolved
Hide resolved
This reverts commit 2b63f8c.
Removes all occurrences of UpdateForV9 annotation owned by Core/Infra that are not blocked