[Transform] Create system index on first put #118003
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Putting a new Transform should create the latest system index if it doesn't already exist, and Transforms should wait for the system index to become fully available since Transforms immediately starts searching over the index. We have existing code to migrate Transforms to new system indices within the PersistentTaskExecutor, we can reuse that when we create new Transforms. This isn't copied to places like Update because: 1. Updates can work on old system indices for existing Transforms, and PersistentTaskExecutor will continue to migrate those Transforms. 2. You cannot update a non-existent Transform anyway. Fix elastic#117995
prwhelan
added
>bug
:ml/Transform
Collaborator
|
Hi @prwhelan, I've created a changelog YAML for you. |
Member
Author
|
@elasticmachine update branch |
Member
Author
|
@elasticmachine update branch |
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Putting a new Transform should create the latest system index if it doesn't already exist, and Transforms should wait for the system index to become fully available since Transforms immediately starts searching over the index.
We have existing code to migrate Transforms to new system indices within the PersistentTaskExecutor, we can reuse that when we create new Transforms.
This isn't copied to places like Update because:
Fix #117995