Skip to content

Update migrate_8_16.asciidoc to include enrich.cache_size breaking ch… #118161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 13, 2025
Merged

Update migrate_8_16.asciidoc to include enrich.cache_size breaking ch… #118161

merged 3 commits into from
Jan 13, 2025

Conversation

ZachBrisson-Elastic
Copy link

…ange

Heya, due to a bug found in https://github.com/elastic/sdh-elasticsearch/issues/8603 a new breaking change was discovered with the enrich.cache_size setting changed to enrich.cache.size parameter. A Support KB now outlines the issue, https://support.elastic.co/knowledge/4821af0d.

This commit adds an "Ingest changes" to the breaking changes section to outline this new behavior, outlining this new behavior. The devs have not confirmed but hope in 8.16.2 for both settings to be available enrich.cache_size (Presently only <8.16 worked) AND enrich.cache.size (Presently only >8.16 works). In a support case this stopped an upgrade entirely on elastic cloud. In self-hosted environments, it would result in an error triggering during the upgrade process.

@ZachBrisson-Elastic
Update migrate_8_16.asciidoc to include enrich.cache_size breaking ch…
9b5546a 
…ange

Heya, due to a bug found in elastic/sdh-elasticsearch#8603 a new breaking change was discovered with the enrich.cache_size setting changed to enrich.cache.size parameter. A Support KB now outlines the issue, https://support.elastic.co/knowledge/4821af0d. 

This commit adds an "Ingest changes" to the breaking changes section to outline this new behavior.
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024

Documentation preview:

@elasticsearchmachine elasticsearchmachine added the needs:triage Requires assignment of a team area label label Dec 6, 2024
@elasticsearchmachine
Copy link
Collaborator

@ZachBrisson-Elastic please enable the option "Allow edits and access to secrets by maintainers" on your PR. For more information, see the documentation.

@elasticsearchmachine elasticsearchmachine added v8.16.2 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Dec 6, 2024
@arteam arteam added :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >docs General docs changes labels Dec 10, 2024
@elasticsearchmachine elasticsearchmachine added Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team and removed needs:triage Requires assignment of a team area label labels Dec 10, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@shainaraskas
Copy link
Contributor

shainaraskas commented Dec 11, 2024 •
edited
Loading

Hi Zach 👋 . Because we carry these migration notes forward, you need to create this PR against the 8.x branch and backport it to 8.16 and 8.17.

@leemthompo
Copy link
Contributor

leemthompo commented Dec 11, 2024 •
edited
Loading

you need to create this PR against the 8.x branch and backport it to 8.16 and 8.17.

I think I created this confusion recently because I misunderstood, but we can actually just slap on backport tags and the automation will cherrypick to whatever version. So shouldn't need additional PRs. :-)

@leemthompo leemthompo added auto-backport Automatically create backport pull requests when merged v8.17.0 v8.18.0 labels Dec 11, 2024
@nielsbauman nielsbauman self-requested a review December 11, 2024 16:07
@nielsbauman nielsbauman self-assigned this Dec 11, 2024
nielsbauman
nielsbauman requested changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@nielsbauman nielsbauman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this, @ZachBrisson-Elastic! I left a comment regarding the phrasing of the breaking change, but I definitely agree we should add an entry.

@nielsbauman
Copy link
Contributor

I'm also adding @dakrone as a reviewer to pass a second pair of Data Management eyes on the change.

@nielsbauman nielsbauman requested a review from dakrone December 12, 2024 16:01
dakrone
dakrone approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I agree with Niels' suggestions

@nielsbauman nielsbauman enabled auto-merge (squash) January 13, 2025 00:55
@nielsbauman nielsbauman merged commit 43b7524 into 8.16 Jan 13, 2025
5 of 6 checks passed
@nielsbauman nielsbauman deleted the ZachBrisson-Elastic-patch-1 branch January 13, 2025 01:15
nielsbauman pushed a commit to nielsbauman/elasticsearch that referenced this pull request Jan 20, 2025
@ZachBrisson-Elastic @nielsbauman
Include enrich.cache_size breaking change in 8.16 doc (elastic#118161)
61b3a19 
This commit adds an "Ingest changes" to the breaking changes section to outline this new behavior.
nielsbauman pushed a commit to nielsbauman/elasticsearch that referenced this pull request Jan 20, 2025
@ZachBrisson-Elastic @nielsbauman
Include enrich.cache_size breaking change in 8.16 doc (elastic#118161)
c85164c 
This commit adds an "Ingest changes" to the breaking changes section to outline this new behavior.
elasticsearchmachine pushed a commit that referenced this pull request Jan 20, 2025
@nielsbauman @ZachBrisson-Elastic
Include enrich.cache_size breaking change in 8.16 doc (#118161) (#120448
3e09b9e 
)

This commit adds an "Ingest changes" to the breaking changes section to outline this new behavior.

Co-authored-by: Zach Brisson <[email protected]>
elasticsearchmachine pushed a commit that referenced this pull request Jan 20, 2025
@nielsbauman @ZachBrisson-Elastic
Include enrich.cache_size breaking change in 8.16 doc (#118161) (#120449
1eda9e5 
)

This commit adds an "Ingest changes" to the breaking changes section to outline this new behavior.

Co-authored-by: Zach Brisson <[email protected]>
This was referenced Feb 11, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dakrone dakrone dakrone approved these changes

@leemthompo leemthompo leemthompo approved these changes

@nielsbauman nielsbauman nielsbauman approved these changes

Assignees

@nielsbauman nielsbauman

Labels

auto-backport Automatically create backport pull requests when merged :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >docs General docs changes external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team v8.16.4 v8.17.0 v8.18.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ZachBrisson-Elastic @elasticsearchmachine @shainaraskas @leemthompo @nielsbauman @dakrone @arteam