[Connector API] Support soft deletes of connectors #118282
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| pr: 118282 | ||
| summary: "[Connector API] Support soft deletes of connectors" | ||
| area: Extract&Transform | ||
| type: feature | ||
| issues: [] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,307 @@ | ||
| { | ||
|
There was a problem hiding this comment. Is it possible to have a test that checks that both deleted and non-deleted indices have the same schema? Additionally, does it make sense to make a lot of properties here searchable? Or we wanna have filters on deleted connectors too? |
||
| "settings": { | ||
| "index": { | ||
| "number_of_shards": "1", | ||
| "auto_expand_replicas": "0-1" | ||
| } | ||
| }, | ||
| "mappings":{ | ||
| "_doc":{ | ||
| "dynamic":"false", | ||
| "_meta": { | ||
| "version": "${connectors-deleted.version}", | ||
| "managed_index_mappings_version": ${connectors-deleted.managed.index.version} | ||
| }, | ||
| "properties":{ | ||
| "api_key_id":{ | ||
| "type":"keyword" | ||
| }, | ||
| "configuration":{ | ||
| "type":"object" | ||
| }, | ||
| "custom_scheduling":{ | ||
| "type":"object" | ||
| }, | ||
| "description":{ | ||
| "type":"text" | ||
| }, | ||
| "error":{ | ||
| "type":"keyword" | ||
| }, | ||
| "features":{ | ||
| "properties":{ | ||
| "filtering_advanced_config":{ | ||
| "type":"boolean" | ||
| }, | ||
| "filtering_rules":{ | ||
| "type":"boolean" | ||
| }, | ||
| "incremental_sync":{ | ||
| "properties":{ | ||
| "enabled":{ | ||
| "type":"boolean" | ||
| } | ||
| } | ||
| }, | ||
| "sync_rules":{ | ||
| "properties":{ | ||
| "advanced":{ | ||
| "properties":{ | ||
| "enabled":{ | ||
| "type":"boolean" | ||
| } | ||
| } | ||
| }, | ||
| "basic":{ | ||
| "properties":{ | ||
| "enabled":{ | ||
| "type":"boolean" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "filtering":{ | ||
| "properties":{ | ||
| "active":{ | ||
| "properties":{ | ||
| "advanced_snippet":{ | ||
| "properties":{ | ||
| "created_at":{ | ||
| "type":"date" | ||
| }, | ||
| "updated_at":{ | ||
| "type":"date" | ||
| }, | ||
| "value":{ | ||
| "type":"object" | ||
| } | ||
| } | ||
| }, | ||
| "rules":{ | ||
| "properties":{ | ||
| "created_at":{ | ||
| "type":"date" | ||
| }, | ||
| "field":{ | ||
| "type":"keyword" | ||
| }, | ||
| "id":{ | ||
| "type":"keyword" | ||
| }, | ||
| "order":{ | ||
| "type":"short" | ||
| }, | ||
| "policy":{ | ||
| "type":"keyword" | ||
| }, | ||
| "rule":{ | ||
| "type":"keyword" | ||
| }, | ||
| "updated_at":{ | ||
| "type":"date" | ||
| }, | ||
| "value":{ | ||
| "type":"keyword" | ||
| } | ||
| } | ||
| }, | ||
| "validation":{ | ||
| "properties":{ | ||
| "errors":{ | ||
| "properties":{ | ||
| "ids":{ | ||
| "type":"keyword" | ||
| }, | ||
| "messages":{ | ||
| "type":"text" | ||
| } | ||
| } | ||
| }, | ||
| "state":{ | ||
| "type":"keyword" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "domain":{ | ||
| "type":"keyword" | ||
| }, | ||
| "draft":{ | ||
| "properties":{ | ||
| "advanced_snippet":{ | ||
| "properties":{ | ||
| "created_at":{ | ||
| "type":"date" | ||
| }, | ||
| "updated_at":{ | ||
| "type":"date" | ||
| }, | ||
| "value":{ | ||
| "type":"object" | ||
| } | ||
| } | ||
| }, | ||
| "rules":{ | ||
| "properties":{ | ||
| "created_at":{ | ||
| "type":"date" | ||
| }, | ||
| "field":{ | ||
| "type":"keyword" | ||
| }, | ||
| "id":{ | ||
| "type":"keyword" | ||
| }, | ||
| "order":{ | ||
| "type":"short" | ||
| }, | ||
| "policy":{ | ||
| "type":"keyword" | ||
| }, | ||
| "rule":{ | ||
| "type":"keyword" | ||
| }, | ||
| "updated_at":{ | ||
| "type":"date" | ||
| }, | ||
| "value":{ | ||
| "type":"keyword" | ||
| } | ||
| } | ||
| }, | ||
| "validation":{ | ||
| "properties":{ | ||
| "errors":{ | ||
| "properties":{ | ||
| "ids":{ | ||
| "type":"keyword" | ||
| }, | ||
| "messages":{ | ||
| "type":"text" | ||
| } | ||
| } | ||
| }, | ||
| "state":{ | ||
| "type":"keyword" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "index_name":{ | ||
| "type":"keyword" | ||
| }, | ||
| "is_native":{ | ||
| "type":"boolean" | ||
| }, | ||
| "language":{ | ||
| "type":"keyword" | ||
| }, | ||
| "last_access_control_sync_error":{ | ||
| "type":"keyword" | ||
| }, | ||
| "last_access_control_sync_scheduled_at":{ | ||
| "type":"date" | ||
| }, | ||
| "last_access_control_sync_status":{ | ||
| "type":"keyword" | ||
| }, | ||
| "last_deleted_document_count":{ | ||
| "type":"long" | ||
| }, | ||
| "last_incremental_sync_scheduled_at":{ | ||
| "type":"date" | ||
| }, | ||
| "last_indexed_document_count":{ | ||
| "type":"long" | ||
| }, | ||
| "last_seen":{ | ||
| "type":"date" | ||
| }, | ||
| "last_sync_error":{ | ||
| "type":"keyword" | ||
| }, | ||
| "last_sync_scheduled_at":{ | ||
| "type":"date" | ||
| }, | ||
| "last_sync_status":{ | ||
| "type":"keyword" | ||
| }, | ||
| "last_synced":{ | ||
| "type":"date" | ||
| }, | ||
| "name":{ | ||
| "type":"keyword" | ||
| }, | ||
| "pipeline":{ | ||
| "properties":{ | ||
| "extract_binary_content":{ | ||
| "type":"boolean" | ||
| }, | ||
| "name":{ | ||
| "type":"keyword" | ||
| }, | ||
| "reduce_whitespace":{ | ||
| "type":"boolean" | ||
| }, | ||
| "run_ml_inference":{ | ||
| "type":"boolean" | ||
| } | ||
| } | ||
| }, | ||
| "scheduling":{ | ||
| "properties":{ | ||
| "access_control":{ | ||
| "properties":{ | ||
| "enabled":{ | ||
| "type":"boolean" | ||
| }, | ||
| "interval":{ | ||
| "type":"text" | ||
| } | ||
| } | ||
| }, | ||
| "full":{ | ||
| "properties":{ | ||
| "enabled":{ | ||
| "type":"boolean" | ||
| }, | ||
| "interval":{ | ||
| "type":"text" | ||
| } | ||
| } | ||
| }, | ||
| "incremental":{ | ||
| "properties":{ | ||
| "enabled":{ | ||
| "type":"boolean" | ||
| }, | ||
| "interval":{ | ||
| "type":"text" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "service_type":{ | ||
| "type":"keyword" | ||
| }, | ||
| "status":{ | ||
| "type":"keyword" | ||
| }, | ||
| "sync_cursor":{ | ||
| "type":"object" | ||
| }, | ||
| "sync_now":{ | ||
| "type":"boolean" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about unmuting the tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It got muted due couple of flakey runs recently ... I checked the logs and it seemed to be weird ES error. It has been running for almost a year now fine