-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[Docs] kNN vector rescoring for quantized vectors #118425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
carlosdelest
merged 26 commits into
elastic:main
from
carlosdelest:feature/knn-vector-rescore-query-docs
Jan 17, 2025
Merged
Changes from 23 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
0844cf8
Use a FunctionScoreQuery to replace scores using a VectorSimilarity b…
carlosdelest 5453003
Add rescore vector builder to KnnSearchBuilder
carlosdelest 6a39c4a
Fix refactoring, spotless
carlosdelest c96a1dc
Check oversampling is not used for quantized types
carlosdelest 37be056
Use KnnRescoreVectorQuery to perform rescoring and limiting the numbe…
carlosdelest 1f2c846
Small name refactoring, fix adjusting parameters
carlosdelest e2ba897
Minor documentation / style fixes
carlosdelest f4de859
Properly implement advanceExact()
carlosdelest eff2be1
Fix VectorSimilarityFloatValueSource implementation for advanceExact
carlosdelest 1e7632c
Correctly implement profiling. Rename ProfilingQuery to QueryProfiler…
carlosdelest c9af11b
Bytes can't be quantized - remove all infra for byte vectors in resco…
carlosdelest 28d929f
Simplify logic for RescoreKnnVectorQuery now that k is not modifiable
carlosdelest 2bd7699
Vector similarity needs to wrap the new rescoring query and not the o…
carlosdelest cc92e2e
Add docs
carlosdelest ec30b45
WIP - Add more docs
carlosdelest 318c6c5
Rewording, adapting to final names in PR
carlosdelest 8ade227
Refactor common params
carlosdelest 4890cd9
Fix rebasing
carlosdelest 6b00373
Fix rebasing
carlosdelest 8785024
Replaced too much
carlosdelest ff7f906
Rescoring options moved to additional section
carlosdelest 9c00564
Added rescore_vector to Search API
carlosdelest c3ee2c3
Change rescore_vector for rescore
carlosdelest 3c60c01
Merge branch 'refs/heads/main' into feature/knn-vector-rescore-query-…
carlosdelest 7b5ac90
Fix naming, use oversample parameter instead of num_candidates_factor
carlosdelest 538d250
Merge branch 'main' into feature/knn-vector-rescore-query-docs
carlosdelest File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we also need to put it in
search-api-knn
insearch.asciidoc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the catch - done in 9c00564