Adding block for max_page_search_size in PivotConfig of new transforms #118607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-rubinstein
added
>enhancement
:ml
elasticsearchmachine
added
the
external-contributor
|
Hi @dan-rubinstein, I've created a changelog YAML for you. |
dan-rubinstein
added
v8.18.0
and removed
external-contributor
|
Closing as this is no longer needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue - https://github.com/elastic/ml-team/issues/1410
TODO: Is there a way to manually test the case where a transform with max_page_search_size in the pivot config from before this change still works?
TODO: Do we have any automated testing for this?
TODO: Is there any other usages of the action aside from creating a new transform?