-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[DOCS] Make Wolfi hardened Docker option more prominent #118755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
f755dbf
[DOCS] Mention Wolfi hardened option in Docker docs
leemthompo e8c3daf
Make Wolfi info more prominent
leemthompo 4453c2e
Add Wolfi docker image variable
leemthompo 190da2e
Somebody already added that variable
leemthompo d10500d
Ditto
leemthompo 871005c
Merge branch 'main' into docker-wolfi-docs
leemthompo f34538f
Ok this file was updated in meantime but tidying it up a bit anyway
leemthompo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd break this out of a tip - feels like part of the primary narrative to me
since this adds security, is using wolfi images the better path? should we recommend it for everyone using an appropriate version of docker?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with the tip point, but also I pulled
main
and discovered this file had already been updated. I tried to make guidance more prominent at the outset in any case;I assume at some point in the future the container will stop needing to be explicitly called out as wolfi once it becomes default.