Skip to content

Conversation

@DaveCTurner
Copy link
Contributor

This test asserts that no AZ attribute is set, assuming that the current
AZ is unavailable, but in fact that's not true when running these tests
in EC2. With this commit we override the IMDS endpoint address to one
that definitely does not exist.

Relates #118675
Closes #118564

This test asserts that no AZ attribute is set, assuming that the current
AZ is unavailable, but in fact that's not true when running these tests
in EC2. With this commit we override the IMDS endpoint address to one
that definitely does not exist.

Relates elastic#118675
Closes elastic#118564
@DaveCTurner DaveCTurner added >test Issues or PRs that are addressing/adding tests :Distributed Coordination/Discovery-Plugins Anything related to our integration plugins with EC2, GCP and Azure v9.0.0 v8.18.0 labels Dec 17, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Distributed Coordination Meta label for Distributed Coordination team label Dec 17, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination)

Copy link
Contributor

@nicktindall nicktindall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaveCTurner DaveCTurner added auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) auto-backport Automatically create backport pull requests when merged labels Dec 27, 2024
@elasticsearchmachine elasticsearchmachine merged commit fe64ae0 into elastic:main Dec 27, 2024
16 checks passed
@DaveCTurner DaveCTurner deleted the 2024/12/12/fix-DiscoveryEc2AvailabilityZoneAttributeNoImdsIT branch December 27, 2024 09:27
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Dec 27, 2024
This test asserts that no AZ attribute is set, assuming that the current
AZ is unavailable, but in fact that's not true when running these tests
in EC2. With this commit we override the IMDS endpoint address to one
that definitely does not exist.

Relates elastic#118675 Closes elastic#118564
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.x

elasticsearchmachine pushed a commit that referenced this pull request Dec 27, 2024
This test asserts that no AZ attribute is set, assuming that the current
AZ is unavailable, but in fact that's not true when running these tests
in EC2. With this commit we override the IMDS endpoint address to one
that definitely does not exist.

Relates #118675 Closes #118564
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Distributed Coordination/Discovery-Plugins Anything related to our integration plugins with EC2, GCP and Azure Team:Distributed Coordination Meta label for Distributed Coordination team >test Issues or PRs that are addressing/adding tests v8.18.0 v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] DiscoveryEc2AvailabilityZoneAttributeNoImdsIT testAvailabilityZoneAttribute failing

3 participants