[Profiling] Aggregate flamegraph by process name and thread name

x-pack/plugin/build.gradle

@@ -111,6 +111,8 @@ tasks.named("yamlRestCompatTestTransform").configure({ task ->
   task.skipTest("esql/40_tsdb/from index pattern unsupported counter", "TODO: support for subset of metric fields")
   task.skipTest("esql/40_unsupported_types/unsupported", "TODO: support for subset of metric fields")
   task.skipTest("esql/40_unsupported_types/unsupported with sort", "TODO: support for subset of metric fields")
+  task.replaceValueInMatch("Size", 49, "Test flamegraph from profiling-events")
+  task.replaceValueInMatch("Size", 49, "Test flamegraph from test-events")
 })
 
 tasks.named('yamlRestCompatTest').configure {

x-pack/plugin/core/template-resources/src/main/resources/profiling/component-template/profiling-events.json

@@ -15,6 +15,7 @@
             "service.name",
             "host.name",
             "container.name",
+            "process.executable.name",
             "process.thread.name",
             "@timestamp"
           ],
@@ -26,6 +27,7 @@
             "asc",
             "asc",
             "asc",
+            "asc",
             "desc"
           ]
         }
@@ -67,6 +69,9 @@
         "process.thread.name": {
           "type": "keyword"
         },
+        "process.executable.name": {
+          "type": "keyword"
+        },
         "Stacktrace.count": {
           "type": "short",
           "index": false

x-pack/plugin/profiling/src/internalClusterTest/java/org/elasticsearch/xpack/profiling/action/GetFlameGraphActionIT.java

@@ -26,10 +26,10 @@ public void testGetStackTracesUnfiltered() throws Exception {
         );
         GetFlamegraphResponse response = client().execute(GetFlamegraphAction.INSTANCE, request).get();
         // only spot-check top level properties - detailed tests are done in unit tests
-        assertEquals(994, response.getSize());
+        assertEquals(1010, response.getSize());
         assertEquals(1.0d, response.getSamplingRate(), 0.001d);
         assertEquals(46, response.getSelfCPU());
-        assertEquals(1903, response.getTotalCPU());
+        assertEquals(1995, response.getTotalCPU());
         assertEquals(46, response.getTotalSamples());
 
         // The root node's values are the same as the top-level values.

x-pack/plugin/profiling/src/internalClusterTest/java/org/elasticsearch/xpack/profiling/action/GetStackTracesActionIT.java

@@ -12,6 +12,7 @@
 import org.elasticsearch.index.query.TermQueryBuilder;
 
 import java.util.List;
+import java.util.Map;
 
 public class GetStackTracesActionIT extends ProfilingTestCase {
     public void testGetStackTracesUnfiltered() throws Exception {
@@ -36,7 +37,11 @@ public void testGetStackTracesUnfiltered() throws Exception {
         assertEquals(1821, response.getTotalFrames());
 
         assertNotNull(response.getStackTraceEvents());
-        assertEquals(3L, response.getStackTraceEvents().get("L7kj7UvlKbT-vN73el4faQ").count);
+
+        Map<TraceEventID, TraceEvent> traceEvents = response.getStackTraceEvents();
+
+        TraceEventID traceEventID = new TraceEventID("", "497295213074376", "8457605156473051743", "L7kj7UvlKbT-vN73el4faQ");
+        assertEquals(3L, response.getStackTraceEvents().get(traceEventID).count);
 
         assertNotNull(response.getStackTraces());
         // just do a high-level spot check. Decoding is tested in unit-tests
@@ -45,8 +50,6 @@ public void testGetStackTracesUnfiltered() throws Exception {
         assertEquals(18, stackTrace.fileIds.length);
         assertEquals(18, stackTrace.frameIds.length);
         assertEquals(18, stackTrace.typeIds.length);
-        assertEquals(0.0000051026469d, stackTrace.annualCO2Tons, 0.0000000001d);
-        assertEquals(0.19825d, stackTrace.annualCostsUSD, 0.00001d);
         // not determined by default
         assertNull(stackTrace.subGroups);
 
@@ -80,7 +83,10 @@ public void testGetStackTracesGroupedByServiceName() throws Exception {
         assertEquals(1821, response.getTotalFrames());
 
         assertNotNull(response.getStackTraceEvents());
-        assertEquals(3L, response.getStackTraceEvents().get("L7kj7UvlKbT-vN73el4faQ").count);
+
+        TraceEventID traceEventID = new TraceEventID("", "497295213074376", "8457605156473051743", "L7kj7UvlKbT-vN73el4faQ");
+        assertEquals(3L, response.getStackTraceEvents().get(traceEventID).count);
+        assertEquals(Long.valueOf(2L), response.getStackTraceEvents().get(traceEventID).subGroups.getCount("basket"));
 
         assertNotNull(response.getStackTraces());
         // just do a high-level spot check. Decoding is tested in unit-tests
@@ -89,9 +95,6 @@ public void testGetStackTracesGroupedByServiceName() throws Exception {
         assertEquals(18, stackTrace.fileIds.length);
         assertEquals(18, stackTrace.frameIds.length);
         assertEquals(18, stackTrace.typeIds.length);
-        assertEquals(0.0000051026469d, stackTrace.annualCO2Tons, 0.0000000001d);
-        assertEquals(0.19825d, stackTrace.annualCostsUSD, 0.00001d);
-        assertEquals(Long.valueOf(2L), stackTrace.subGroups.getCount("basket"));
 
         assertNotNull(response.getStackFrames());
         StackFrame stackFrame = response.getStackFrames().get("8NlMClggx8jaziUTJXlmWAAAAAAAAIYI");
@@ -127,8 +130,13 @@ public void testGetStackTracesFromAPMWithMatchNoDownsampling() throws Exception
         assertEquals(1.0d, response.getSamplingRate(), 0.001d);
 
         assertNotNull(response.getStackTraceEvents());
-        assertEquals(3L, response.getStackTraceEvents().get("Ce77w10WeIDow3kd1jowlA").count);
-        assertEquals(2L, response.getStackTraceEvents().get("JvISdnJ47BQ01489cwF9DA").count);
+
+        TraceEventID traceEventID = new TraceEventID("", "", "", "Ce77w10WeIDow3kd1jowlA");
+        assertEquals(3L, response.getStackTraceEvents().get(traceEventID).count);
+        assertEquals(Long.valueOf(3L), response.getStackTraceEvents().get(traceEventID).subGroups.getCount("encodeSha1"));
+
+        traceEventID = new TraceEventID("", "", "", "JvISdnJ47BQ01489cwF9DA");
+        assertEquals(2L, response.getStackTraceEvents().get(traceEventID).count);
 
         assertNotNull(response.getStackTraces());
         // just do a high-level spot check. Decoding is tested in unit-tests
@@ -137,9 +145,6 @@ public void testGetStackTracesFromAPMWithMatchNoDownsampling() throws Exception
         assertEquals(39, stackTrace.fileIds.length);
         assertEquals(39, stackTrace.frameIds.length);
         assertEquals(39, stackTrace.typeIds.length);
-        assertTrue(stackTrace.annualCO2Tons > 0.0d);
-        assertTrue(stackTrace.annualCostsUSD > 0.0d);
-        assertEquals(Long.valueOf(3L), stackTrace.subGroups.getCount("encodeSha1"));
 
         assertNotNull(response.getStackFrames());
         StackFrame stackFrame = response.getStackFrames().get("fhsEKXDuxJ-jIJrZpdRuSAAAAAAAAFtj");
@@ -175,9 +180,13 @@ public void testGetStackTracesFromAPMWithMatchAndDownsampling() throws Exception
         assertEquals(0.2d, response.getSamplingRate(), 0.001d);
 
         assertNotNull(response.getStackTraceEvents());
+
         // as the sampling rate is 0.2, we see 5 times more samples (random sampler agg automatically adjusts sample count)
-        assertEquals(5 * 3L, response.getStackTraceEvents().get("Ce77w10WeIDow3kd1jowlA").count);
-        assertEquals(5 * 2L, response.getStackTraceEvents().get("JvISdnJ47BQ01489cwF9DA").count);
+        TraceEventID traceEventID = new TraceEventID("", "", "", "Ce77w10WeIDow3kd1jowlA");
+        assertEquals(5 * 3L, response.getStackTraceEvents().get(traceEventID).count);
+
+        traceEventID = new TraceEventID("", "", "", "JvISdnJ47BQ01489cwF9DA");
+        assertEquals(5 * 2L, response.getStackTraceEvents().get(traceEventID).count);
 
         assertNotNull(response.getStackTraces());
         // just do a high-level spot check. Decoding is tested in unit-tests
@@ -186,8 +195,6 @@ public void testGetStackTracesFromAPMWithMatchAndDownsampling() throws Exception
         assertEquals(39, stackTrace.fileIds.length);
         assertEquals(39, stackTrace.frameIds.length);
         assertEquals(39, stackTrace.typeIds.length);
-        assertTrue(stackTrace.annualCO2Tons > 0.0d);
-        assertTrue(stackTrace.annualCostsUSD > 0.0d);
         // not determined by default
         assertNull(stackTrace.subGroups);
 

x-pack/plugin/profiling/src/main/java/org/elasticsearch/xpack/profiling/action/GetStackTracesResponse.java

@@ -29,7 +29,7 @@ public class GetStackTracesResponse extends ActionResponse implements ChunkedToX
     @Nullable
     private final Map<String, String> executables;
     @Nullable
-    private final Map<String, TraceEvent> stackTraceEvents;
+    private final Map<TraceEventID, TraceEvent> stackTraceEvents;
     private final int totalFrames;
     private final double samplingRate;
     private final long totalSamples;
@@ -38,7 +38,7 @@ public GetStackTracesResponse(
         Map<String, StackTrace> stackTraces,
         Map<String, StackFrame> stackFrames,
         Map<String, String> executables,
-        Map<String, TraceEvent> stackTraceEvents,
+        Map<TraceEventID, TraceEvent> stackTraceEvents,
         int totalFrames,
         double samplingRate,
         long totalSamples
@@ -69,7 +69,7 @@ public Map<String, String> getExecutables() {
         return executables;
     }
 
-    public Map<String, TraceEvent> getStackTraceEvents() {
+    public Map<TraceEventID, TraceEvent> getStackTraceEvents() {
         return stackTraceEvents;
     }
 
@@ -96,22 +96,24 @@ public Iterator<? extends ToXContent> toXContentChunked(ToXContent.Params params
             optional(
                 "stack_trace_events",
                 stackTraceEvents,
-                (n, v) -> ChunkedToXContentHelper.object(n, v, entry -> (b, p) -> b.field(entry.getKey(), entry.getValue().count))
+                (n, v) -> ChunkedToXContentHelper.object(
+                    n,
+                    Iterators.map(v.entrySet().iterator(), e -> (b, p) -> b.field(e.getKey().stacktraceID(), e.getValue().count))
+                )
             ),
-            Iterators.single((b, p) -> b.field("sampling_rate", samplingRate)),
+            Iterators.single((b, p) -> b.field("sampling_rate", samplingRate).endObject())
             // the following fields are intentionally not written to the XContent representation (only needed on the transport layer):
             //
             // * start
             // * end
             // * totalSamples
-            ChunkedToXContentHelper.endObject()
         );
     }
 
-    private static <T> Iterator<? extends ToXContent> optional(
+    private static <K, T> Iterator<? extends ToXContent> optional(
         String name,
-        Map<String, T> values,
-        BiFunction<String, Map<String, T>, Iterator<? extends ToXContent>> supplier
+        Map<K, T> values,
+        BiFunction<String, Map<K, T>, Iterator<? extends ToXContent>> supplier
     ) {
         return (values != null) ? supplier.apply(name, values) : Collections.emptyIterator();
     }

x-pack/plugin/profiling/src/main/java/org/elasticsearch/xpack/profiling/action/GetStackTracesResponseBuilder.java

@@ -8,7 +8,6 @@
 package org.elasticsearch.xpack.profiling.action;
 
 import java.time.Instant;
-import java.util.List;
 import java.util.Map;
 
 class GetStackTracesResponseBuilder {
@@ -18,8 +17,7 @@ class GetStackTracesResponseBuilder {
     private int totalFrames;
     private Map<String, StackFrame> stackFrames;
     private Map<String, String> executables;
-    private Map<String, TraceEvent> stackTraceEvents;
-    private List<TransportGetStackTracesAction.HostEventCount> hostEventCounts;
+    private Map<TraceEventID, TraceEvent> stackTraceEvents;
     private double samplingRate;
     private long totalSamples;
     private Double requestedDuration;
@@ -67,19 +65,11 @@ public void setExecutables(Map<String, String> executables) {
         this.executables = executables;
     }
 
-    public void setStackTraceEvents(Map<String, TraceEvent> stackTraceEvents) {
+    public void setStackTraceEvents(Map<TraceEventID, TraceEvent> stackTraceEvents) {
         this.stackTraceEvents = stackTraceEvents;
     }
 
-    public void setHostEventCounts(List<TransportGetStackTracesAction.HostEventCount> hostEventCounts) {
-        this.hostEventCounts = hostEventCounts;
-    }
-
-    public List<TransportGetStackTracesAction.HostEventCount> getHostEventCounts() {
-        return hostEventCounts;
-    }
-
-    public Map<String, TraceEvent> getStackTraceEvents() {
+    public Map<TraceEventID, TraceEvent> getStackTraceEvents() {
         return stackTraceEvents;
     }
 
@@ -149,17 +139,17 @@ public void setTotalSamples(long totalSamples) {
     public GetStackTracesResponse build() {
         // Merge the TraceEvent data into the StackTraces.
         if (stackTraces != null) {
-            for (Map.Entry<String, StackTrace> entry : stackTraces.entrySet()) {
-                String stacktraceID = entry.getKey();
-                TraceEvent event = stackTraceEvents.get(stacktraceID);
-                if (event != null) {
-                    StackTrace stackTrace = entry.getValue();
-                    stackTrace.count = event.count;
+            for (Map.Entry<TraceEventID, TraceEvent> entry : stackTraceEvents.entrySet()) {
+                TraceEventID traceEventID = entry.getKey();
+                StackTrace stackTrace = stackTraces.get(traceEventID.stacktraceID());
+                if (stackTrace != null) {
+                    TraceEvent event = entry.getValue();
                     if (event.subGroups != null) {
                         stackTrace.subGroups = event.subGroups;
                     }
-                    stackTrace.annualCO2Tons = event.annualCO2Tons;
-                    stackTrace.annualCostsUSD = event.annualCostsUSD;
+                    stackTrace.count += event.count;
+                    stackTrace.annualCO2Tons += event.annualCO2Tons;
+                    stackTrace.annualCostsUSD += event.annualCostsUSD;
                 }
             }
         }

x-pack/plugin/profiling/src/main/java/org/elasticsearch/xpack/profiling/action/StackTrace.java

@@ -31,22 +31,14 @@ final class StackTrace implements ToXContentObject {
     double annualCostsUSD;
     long count;
 
-    StackTrace(
-        int[] addressOrLines,
-        String[] fileIds,
-        String[] frameIds,
-        int[] typeIds,
-        double annualCO2Tons,
-        double annualCostsUSD,
-        long count
-    ) {
+    StackTrace(int[] addressOrLines, String[] fileIds, String[] frameIds, int[] typeIds) {
         this.addressOrLines = addressOrLines;
         this.fileIds = fileIds;
         this.frameIds = frameIds;
         this.typeIds = typeIds;
-        this.annualCO2Tons = annualCO2Tons;
-        this.annualCostsUSD = annualCostsUSD;
-        this.count = count;
+        annualCO2Tons = 0.0d;
+        annualCostsUSD = 0.0d;
+        count = 0;
     }
 
     private static final int BASE64_FRAME_ID_LENGTH = 32;
@@ -218,7 +210,7 @@ public static StackTrace fromSource(Map<String, Object> source) {
         // Step 2: Convert the run-length byte encoding into a list of uint8s.
         int[] typeIDs = runLengthDecodeBase64Url(inputFrameTypes, inputFrameTypes.length(), countsFrameIDs);
 
-        return new StackTrace(addressOrLines, fileIDs, frameIDs, typeIDs, 0, 0, 0);
+        return new StackTrace(addressOrLines, fileIDs, frameIDs, typeIDs);
     }
 
     public void forNativeAndKernelFrames(Consumer<String> consumer) {
@@ -232,15 +224,15 @@ public void forNativeAndKernelFrames(Consumer<String> consumer) {
 
     @Override
     public XContentBuilder toXContent(XContentBuilder builder, Params params) throws IOException {
-        builder.startObject();
-        builder.field("address_or_lines", this.addressOrLines);
-        builder.field("file_ids", this.fileIds);
-        builder.field("frame_ids", this.frameIds);
-        builder.field("type_ids", this.typeIds);
-        builder.field("annual_co2_tons", this.annualCO2Tons);
-        builder.field("annual_costs_usd", this.annualCostsUSD);
-        builder.field("count", this.count);
-        builder.endObject();
+        builder.startObject()
+            .field("address_or_lines", this.addressOrLines)
+            .field("file_ids", this.fileIds)
+            .field("frame_ids", this.frameIds)
+            .field("type_ids", this.typeIds)
+            .field("annual_co2_tons", this.annualCO2Tons)
+            .field("annual_costs_usd", this.annualCostsUSD)
+            .field("count", this.count)
+            .endObject();
         return builder;
     }
 

x-pack/plugin/profiling/src/main/java/org/elasticsearch/xpack/profiling/action/TraceEvent.java

@@ -7,53 +7,29 @@
 
 package org.elasticsearch.xpack.profiling.action;
 
-import java.util.Objects;
-
 final class TraceEvent {
-    final String stacktraceID;
+    long count;
     double annualCO2Tons;
     double annualCostsUSD;
-    long count;
     SubGroup subGroups;
 
-    TraceEvent(String stacktraceID) {
-        this(stacktraceID, 0);
+    TraceEvent() {
+        this(0);
     }
 
-    TraceEvent(String stacktraceID, long count) {
-        this.stacktraceID = stacktraceID;
+    TraceEvent(long count) {
         this.count = count;
     }
 
-    @Override
-    public boolean equals(Object o) {
-        if (this == o) {
-            return true;
-        }
-        if (o == null || getClass() != o.getClass()) {
-            return false;
-        }
-        TraceEvent event = (TraceEvent) o;
-        return count == event.count && Objects.equals(stacktraceID, event.stacktraceID);
-    }
-
-    @Override
-    public int hashCode() {
-        return Objects.hash(stacktraceID, count);
-    }
-
     @Override
     public String toString() {
         return "TraceEvent{"
-            + "stacktraceID='"
-            + stacktraceID
-            + '\''
+            + "count="
+            + count
             + ", annualCO2Tons="
             + annualCO2Tons
             + ", annualCostsUSD="
             + annualCostsUSD
-            + ", count="
-            + count
             + ", subGroups="
             + subGroups
             + '}';