[ES|QL] Aggregate Metric Double field type #119171
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds type enums and loads only default field
limotova
commented
Dec 20, 2024
| @@ -0,0 +1,2 @@ | |||
| some_field:aggregate_metric_double | |||
Contributor
Author
There was a problem hiding this comment.
I put this here as a placeholder but I'm not quite sure how we would want to format the csv tests for this type (it might not be possible?)
ensures that default metric can be returned in es|ql. Additionally also let max aggregate function work with aggregate_metric_double, because max metric is the default metric in case of aggregate_metric_double fields in downsampled indices.
…type is kind of supported
Contributor
Author
|
Going with different approach #120343 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loads all 4 subfields into CompositeBlock and renders a single field