Fix usage API docs test #119192
Merged
Fix usage API docs test #119192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures the usage API docs tests are passing again. We achieve this by: 1. ignoring the contents of `inference.models` because the models might not yet have been initialized and 2. adding missing fields to the `logsdb` usage.
nielsbauman
added
>test
|
Documentation preview: |
|
Pinging @elastic/es-data-management (Team:Data Management) |
nielsbauman
requested review from
joegallo and
masseyke
and removed request for
joegallo
PeteGillinElastic
approved these changes
Dec 23, 2024
| "count": 1 | ||
| }, | ||
| "models" : [ | ||
| ... |
There was a problem hiding this comment.
I didn't know you could do this, so I learnt something today!
masseyke
approved these changes
Dec 23, 2024
nielsbauman
added
the
auto-backport
💔 Backport failed
You can use sqren/backport to manually backport by running |
nielsbauman
added a commit
to nielsbauman/elasticsearch
that referenced
this pull request
Dec 23, 2024
This ensures the usage API docs tests are passing again. We achieve this by: 1. ignoring the contents of `inference.models` because the models might not yet have been initialized and 2. adding missing fields to the `logsdb` usage.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures the usage API docs tests are passing again. We achieve this by: 1. ignoring the contents of
inference.modelsbecause the models might not yet have been initialized and 2. adding missing fields to thelogsdbusage.Fixes #113694