Remove redundant ShardIterator interface #119452
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This interface is single use only. No need for the indirection.
original-brownbear
added
>non-issue
:Search Foundations/Search
elasticsearchmachine
added
Team:Search Foundations
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
javanna
requested changes
Jan 6, 2025
|
@javanna lets do that in a separate PR, the otherwise the diff on the iterator file is gonna be a nightmare if we rename and change content? |
|
Actually nevermind Luca :) Diff isn't great with the rename but still quite a bit shorter overall, added the rename here now :) |
|
I ended up opening #121893 after which I had a deja vu and realized we had discussed it a while ago. Let's close this one as it's outdated and get mine merged at this point? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This interface was single use only. No need for the indirection.