Skip to content

Conversation

stefnestor
Copy link
Contributor

👋 howdy, ES Dev!

Will you kindly confirm for Split API doc

  1. Current doc states ... . My belief is that we're telling customers they need sufficient disk on each node hosting primary shards of the index which are going to be split out. AFAICT the doc does not currently otherwise help users judge which node will "handle the split process" which could randomly be master-only in which case this callout would feel invalid.

    The node handling the split process must have sufficient free disk space to accommodate a second copy of the existing index.

  2. If Elastic Cloud hard-link not supported (internal link) restriction is ongoing?

TLDR: Can we add expectations about where split api's created primary shards will allocate so users know where to ensure sufficient disk?

🙏 TIA!

👋 howdy, ES Dev! 

Will you kindly confirm for [Split API](https://www.elastic.co/guide/en/elasticsearch/reference/master/indices-split-index.html) doc
1. Current doc states ... . My belief is that we're telling customers they need sufficient disk on each node hosting primary shards of the index which are going to be split out. AFAICT the doc does not currently otherwise help users judge which node will "handle the split process" which could randomly be master-only in which case this callout would feel wrong.

    > The node handling the split process must have sufficient free disk space to accommodate a second copy of the existing index. 

2. If Elastic Cloud [hard-link not supported](https://support.elastic.dev/knowledge/view/d2cd7697) (internal link) restriction is ongoing?

🙏 TIA!
@stefnestor stefnestor added >docs General docs changes :Data Management/Indices APIs APIs to create and manage indices and templates Team:Data Management Meta label for data/management team labels Jan 8, 2025
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Documentation preview:

@elasticsearchmachine elasticsearchmachine added the Team:Docs Meta label for docs team label Jan 8, 2025
@elasticsearchmachine
Copy link
Collaborator

@stefnestor please enable the option "Allow edits and access to secrets by maintainers" on your PR. For more information, see the documentation.

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@elasticsearchmachine elasticsearchmachine added v9.0.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Jan 8, 2025
@lcawl
Copy link
Contributor

lcawl commented Jan 8, 2025

Hi! This is a drive-by comment that the page affected by this PR will be removed from the main branch soon. To avoid loss of this information, it should also be added here: https://github.com/elastic/elasticsearch-specification/blob/main/specification/indices/split/IndicesSplitRequest.ts

@leemthompo leemthompo requested a review from kingherc January 29, 2025 10:41
index, but with a larger number of primary shards.
index, but with a larger number of primary shards. Created shards allocate
to the same nodes as their correlating source primary shard, so it must
already have sufficient disk to host the copy of the data.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After consulting @tlrx (thanks!) indeed if the shards are on different nodes, the new index shards will be allocated and split on the nodes of their corresponding shards.

We should probably also clarify the above in the following sentence later in the document:

The node handling the split process must have sufficient free disk space to accommodate a second copy of the existing index.

to something like

The nodes handling the split process must have sufficient free disk space to accommodate a second copy of the original shards.

the file system doesn't support hard-linking, then all segments are copied
into the new index, which is a much more time consuming process.)
+
TIP: Elastic Cloud's backing file systems do not support hard linking.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably best answered by @elastic/es-core-infra team who did #61145 . Adding the author of that PR to this (but anyone from the team feel free to step in to review).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding #61145, we did merge a change for it but ended up removing it because, it turned out, Cloud was in fact using a filesystem that correctly reported quotas (XFS IIRC).

Regarding this tip in the docs, I can only imagine it has something to do with attempting to hard-link across Docker volumes, which doesn't work, but you'd need to check with someone from the Hosted ESS team to get an up-to-date answer.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stefnestor might you know who to include from Hosted ESS team to pitch in / review?

@kingherc kingherc added the :Core/Infra/Core Core issues without another label label Jan 29, 2025
@kingherc kingherc requested a review from pugnascotia January 29, 2025 11:48
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Jan 29, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@leemthompo
Copy link
Contributor

Important

Elastic documentation is migrating to Markdown for version 9.0+. See the migration guide for details.

ℹ️ What's happening?

  • Starting January 29, we will start closing all unmerged documentation PRs targeting main/master
  • We're migrating from AsciiDoc to Markdown for 9.0+
  • 9.0 docs will be frozen from January 29 until February 20 2024
  • NOTE: PRs that include both code and documentation changes will remain open

What do I need to do?

For <=8.x docs:

  1. Rebase your PR to target the relevant 8.x branch instead
  2. The content can remain in AsciiDoc format

For 9.0+ docs:

Option 1:

  • Draft docs in Markdown
  • Once migration freeze ends, find the relevant page in the new docs system and use the edit options to submit your changes

Option 2:

💡 Need help?

  1. For Elasticians: Ask in #docs Slack channel
  2. For external contributors: Open an issue in elastic/docs-content

@stefnestor
Copy link
Contributor Author

Closing as new doc system.

@stefnestor stefnestor closed this Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Core/Infra/Core Core issues without another label :Data Management/Indices APIs APIs to create and manage indices and templates >docs General docs changes external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Core/Infra Meta label for core/infra team Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants