Skip to content

[8.17] [Inference API] Fix bug checking for e5 or reranker default IDs (#119797) #119852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 9, 2025
Merged

[8.17] [Inference API] Fix bug checking for e5 or reranker default IDs (#119797) #119852

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e948573
[Inference API] Fix bug checking for e5 or reranker default IDs (#119…
maxhniebergall Jan 9, 2025
ff36d5a
Merge branch '8.17' into backport/8.17/pr-119797
maxhniebergall Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/changelog/119797.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
pr: 119797
summary: "[Inference API] Fix bug checking for e5 or reranker default IDs"
area: Machine Learning
type: bug
issues: []
2 changes: 1 addition & 1 deletion ...rg/elasticsearch/xpack/inference/services/elasticsearch/ElasticsearchInternalService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ public void parseRequestConfig(
Map<String, Object> config,
ActionListener<Model> modelListener
) {
if (inferenceEntityId.equals(DEFAULT_ELSER_ID)) {
if (isDefaultId(inferenceEntityId)) {
modelListener.onFailure(
new ElasticsearchStatusException(
"[{}] is a reserved inference Id. Cannot create a new inference endpoint with a reserved Id",
Expand Down