Skip to content

Fix knn query tests as we now do queries with k #119942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 14, 2025
Merged

Fix knn query tests as we now do queries with k #119942

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
efba3ad
Fix knn query tests as we now do queries with k
benwtrent Jan 10, 2025
f842326
Merge branch '8.x' into tests/fix-knn-query-bwc-tests
benwtrent Jan 13, 2025
eb3a2f6
Merge branch '8.x' into tests/fix-knn-query-bwc-tests
benwtrent Jan 14, 2025
5d58145
Merge branch '8.x' into tests/fix-knn-query-bwc-tests
benwtrent Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions muted-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,12 +416,6 @@ tests:
- class: org.elasticsearch.upgrades.SearchStatesIT
method: testCanMatch
issue: https://github.com/elastic/elasticsearch/issues/118718
- class: org.elasticsearch.backwards.MixedClusterClientYamlTestSuiteIT
method: "test {p0=search.vectors/110_knn_query_with_filter/PRE_FILTER: knn query with internal filter as pre-filter}"
issue: https://github.com/elastic/elasticsearch/issues/119804
- class: org.elasticsearch.backwards.MixedClusterClientYamlTestSuiteIT
method: "test {p0=search.vectors/110_knn_query_with_filter/PRE_FILTER: knn query with alias filter as pre-filter}"
issue: https://github.com/elastic/elasticsearch/issues/119805
- class: org.elasticsearch.backwards.MixedClusterClientYamlTestSuiteIT
issue: https://github.com/elastic/elasticsearch/issues/119806
- class: org.elasticsearch.search.profile.dfs.DfsProfilerIT
Expand Down
4 changes: 2 additions & 2 deletions ...rc/yamlRestTest/resources/rest-api-spec/test/search.vectors/110_knn_query_with_filter.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# test how knn query interacts with filters
setup:
- requires:
cluster_features: "gte_v8.12.0"
reason: 'knn as query added in 8.12'
cluster_features: "search.vectors.k_param_supported"
reason: 'k param for knn as query is required'

- do:
indices.create:
Expand Down