Skip to content

Fix error in QSTR docs #120026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 13, 2025
Merged

Fix error in QSTR docs #120026

merged 1 commit into from
Jan 13, 2025

Conversation

carlosdelest
Copy link
Member

@carlosdelest carlosdelest commented Jan 13, 2025 •
edited
Loading

QSTR docs include by mistake the following tech preview note:

Screenshot 2025-01-13 at 09 20 44

VALUES should be removed from that description. This is fixed in main by #112792 but not backported to 8.x branches.

@carlosdelest carlosdelest added >docs General docs changes Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) auto-backport Automatically create backport pull requests when merged v8.16.0 v8.17.0 labels Jan 13, 2025
@github-actions GitHub Actions
Copy link
Contributor

Documentation preview:

@elasticsearchmachine elasticsearchmachine added v8.18.0 Team:Docs Meta label for docs team and removed Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) labels Jan 13, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

leemthompo
leemthompo approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlosdelest carlosdelest enabled auto-merge (squash) January 13, 2025 08:27
@carlosdelest carlosdelest merged commit faf5665 into 8.x Jan 13, 2025
6 of 7 checks passed
@carlosdelest carlosdelest deleted the docs/esql-qstr-fix-docs branch January 13, 2025 08:44
carlosdelest added a commit to carlosdelest/elasticsearch that referenced this pull request Jan 13, 2025
@carlosdelest
ESQL - Update QSTR docs (elastic#120026)
1c6541f
This was referenced Jan 13, 2025
Merged
Merged
carlosdelest added a commit to carlosdelest/elasticsearch that referenced this pull request Jan 13, 2025
@carlosdelest
ESQL - Update QSTR docs (elastic#120026)
ed86a1b
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 8.16
✅ 8.17

elasticsearchmachine pushed a commit that referenced this pull request Jan 13, 2025
@carlosdelest
ESQL - Update QSTR docs (#120026) (#120028)
4705bde
elasticsearchmachine pushed a commit that referenced this pull request Jan 13, 2025
@carlosdelest
ESQL - Update QSTR docs (#120026) (#120029)
c42f61e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leemthompo leemthompo leemthompo approved these changes

@tteofili tteofili Awaiting requested review from tteofili

@afoucret afoucret Awaiting requested review from afoucret

@ioanatia ioanatia Awaiting requested review from ioanatia

Assignees

No one assigned

Labels

auto-backport Automatically create backport pull requests when merged >docs General docs changes Team:Docs Meta label for docs team v8.16.0 v8.17.0 v8.18.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@carlosdelest @elasticsearchmachine @leemthompo