-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Adding linear retriever to support weighted sums of sub-retrievers #120222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 33 commits
Commits
Show all changes
78 commits
Select commit
Hold shift + click to select a range
825683f
iter
pmpailis 6968760
Merge remote-tracking branch 'origin/main' into add_linear_retriever
pmpailis 6712fc6
Merge remote-tracking branch 'origin/main' into add_linear_retriever
pmpailis 466c026
iter
pmpailis a4259cd
Merge remote-tracking branch 'origin/main' into add_linear_retriever
pmpailis a7da4f3
iter
pmpailis 02db9d0
iter
pmpailis d64effa
iter
pmpailis b945acf
iter
pmpailis 0c1b235
iter
pmpailis c97d27b
iter
pmpailis 2d78404
iter
pmpailis c69b75b
Merge remote-tracking branch 'origin/main' into add_linear_retriever
pmpailis 06d727a
[CI] Auto commit changes from spotless
822ff1d
iter
pmpailis f2eb82c
Merge branch 'add_linear_retriever' of github.com:pmpailis/elasticsea…
pmpailis 020cd78
Update docs/changelog/120222.yaml
pmpailis 8d0583a
iter
pmpailis 8ec4110
iter
pmpailis ceaf3b5
iter
pmpailis ed78bf2
iter
pmpailis a70b0d6
iter
pmpailis 9304c7b
iter
pmpailis 05aae70
iter
pmpailis 4fde947
addressing PR comments - removing lower_bound and upper_bound params
pmpailis e71b25e
fix test
pmpailis 21a78d5
addressing PR comments - removing ScoreNormalizerParser
pmpailis 77fd4e1
removing export from module info
pmpailis a79b280
iter
pmpailis ff0c8c3
spotless
pmpailis 8d53d73
addressing PR comments - updating linear component parsing
pmpailis 86db0bc
fix test
pmpailis d7ab2ce
Merge branch 'main' into add_linear_retriever
pmpailis cc2c071
iter
pmpailis 90ef7f3
addressing PR comments - adding exception for unknown tokens during p…
pmpailis 30123ac
Merge branch 'add_linear_retriever' of github.com:pmpailis/elasticsea…
pmpailis ecea688
Merge branch 'main' into add_linear_retriever
pmpailis 7d6feed
iter
pmpailis 83f9614
Merge remote-tracking branch 'origin/main' into add_linear_retriever
pmpailis 512952d
reverting optimization to avoid populating rank docs for explain, as …
pmpailis 4f97a81
moving linear retriever to xpack and adding integ tests
pmpailis 6294917
fixing license
pmpailis 78fdcda
adding integ tests
pmpailis 5b253aa
iter
pmpailis 1eca5fe
add license test
pmpailis 1f36e18
checkstyle
pmpailis 43cd490
Merge remote-tracking branch 'origin/main' into add_linear_retriever
pmpailis 33bc324
[CI] Auto commit changes from spotless
4d82e28
moving tests
pmpailis cfcd84f
checkstyle
pmpailis 174e0d0
adding missing writeables for tests
pmpailis c0943cb
Merge branch 'main' into add_linear_retriever
pmpailis aeacd33
addressing PR comments
pmpailis 58e2887
fixing tests after refactoring
pmpailis c8a0e1e
Merge remote-tracking branch 'origin/main' into add_linear_retriever
pmpailis 29438ee
iter
pmpailis 7d3f36c
[CI] Auto commit changes from spotless
8677263
iter
pmpailis d961f22
updating parsing to use a static parser
pmpailis 7a31b09
Merge branch 'add_linear_retriever' of github.com:pmpailis/elasticsea…
pmpailis f973d73
Merge branch 'main' into add_linear_retriever
pmpailis 3640ae1
avoid populating LinearRankDoc metadata if not explain
pmpailis da84e03
Merge branch 'main' into add_linear_retriever
pmpailis 9259159
addressing PR comments - simplifying linear score computation
pmpailis ea1787f
addressing PR comments - adding yaml test for linear retriever with i…
pmpailis ce8f60f
removing custom min max options for normalizer
pmpailis 2bda448
adding assertion for negative weights
pmpailis 669e94d
Merge branch 'main' into add_linear_retriever
pmpailis 8b07ea5
updating tests after latest changes
pmpailis ccc2f8a
Merge branch 'main' into add_linear_retriever
pmpailis 3ba0587
Update common-parms.asciidoc
pmpailis 3237ef5
Update retrievers-examples.asciidoc
pmpailis a7425c4
Merge branch 'main' into add_linear_retriever
pmpailis 173f254
setting knn field to flat
pmpailis 42c543a
adding ids to parameter sections for retriever docs
pmpailis 9b40cf6
Merge branch 'main' into add_linear_retriever
pmpailis 95842cc
Merge branch 'main' into add_linear_retriever
pmpailis 21bbb92
Merge branch 'main' into add_linear_retriever
pmpailis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
pr: 120222 | ||
summary: Adding linear retriever to support weighted sums of sub-retrievers | ||
area: "Search" | ||
type: enhancement | ||
issues: [] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this endpoint available by default yet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm not sure, I had this as a custom endpoint for testing/documentation purposes :D . We can refactor though to use the default endpoint (once, if not already, available).