Allow overriding of module metadata files in integration tests #120427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-vieira
added
>test
Collaborator
|
Pinging @elastic/es-delivery (Team:Delivery) |
rjernst
approved these changes
Jan 18, 2025
| override.getValue().apply("").transferTo(output); | ||
| output.closeEntry(); | ||
| } | ||
| ; |
Contributor
Author
There was a problem hiding this comment.
No idea where the extra semi-colon came from. Removed.
This was referenced Jan 18, 2025
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Jan 18, 2025
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Jan 18, 2025
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Jan 18, 2025
Collaborator
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 18, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 18, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #120245 which adds similar functionality for modules, in addition to plugins. Also allows for providing overrides even when the original metadata file is missing.