Remove remaining frozen indices functionality #120539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeteGillinElastic
force-pushed
the
frozen-indices-remove-setting
branch
3 times, most recently
from
c3913c6 to
3b3537e
Compare
This removes the transport action and the index setting. The deprecation check has to go because the setting it uses to detect frozen indices has gone. We are issueing a critical deprecation warning in 8.last telling users to unfreeze them. A lot of integration tests under `x-pack/plugin/sql` also have to go, because they rely on being able to freeze indices.
PeteGillinElastic
force-pushed
the
frozen-indices-remove-setting
branch
from
b0abcda to
74ad654
Compare
PeteGillinElastic
added
:Data Management/Indices APIs
elasticsearchmachine
added
the
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
mattkime
added a commit
to elastic/kibana
that referenced
this pull request
Jan 31, 2025
## Summary This change follows from elastic/elasticsearch#120539 'frozen' attribute will no longer be returned in 9.0 and greater since there are no longer frozen indices Closes: #208873
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 31, 2025
## Summary This change follows from elastic/elasticsearch#120539 'frozen' attribute will no longer be returned in 9.0 and greater since there are no longer frozen indices Closes: elastic#208873 (cherry picked from commit ab9492c)
kibanamachine
added a commit
to elastic/kibana
that referenced
this pull request
Jan 31, 2025
# Backport This will backport the following commits from `main` to `9.0`: - [[index management] unskip api integration test (#209034)](#209034) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Matthew Kime","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-31T11:31:41Z","message":"[index management] unskip api integration test (#209034)\n\n## Summary\r\n\r\nThis change follows from\r\nhttps://github.com/elastic/elasticsearch/pull/120539\r\n\r\n'frozen' attribute will no longer be returned in 9.0 and greater since\r\nthere are no longer frozen indices\r\n\r\nCloses: https://github.com/elastic/kibana/issues/208873","sha":"ab9492c107a8ea2ca20bcb495f9c508a3b1e0037","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Index Management","Team:Kibana Management","release_note:skip","backport:prev-minor","v9.1.0"],"title":"[index management] unskip api integration test","number":209034,"url":"https://github.com/elastic/kibana/pull/209034","mergeCommit":{"message":"[index management] unskip api integration test (#209034)\n\n## Summary\r\n\r\nThis change follows from\r\nhttps://github.com/elastic/elasticsearch/pull/120539\r\n\r\n'frozen' attribute will no longer be returned in 9.0 and greater since\r\nthere are no longer frozen indices\r\n\r\nCloses: https://github.com/elastic/kibana/issues/208873","sha":"ab9492c107a8ea2ca20bcb495f9c508a3b1e0037"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209034","number":209034,"mergeCommit":{"message":"[index management] unskip api integration test (#209034)\n\n## Summary\r\n\r\nThis change follows from\r\nhttps://github.com/elastic/elasticsearch/pull/120539\r\n\r\n'frozen' attribute will no longer be returned in 9.0 and greater since\r\nthere are no longer frozen indices\r\n\r\nCloses: https://github.com/elastic/kibana/issues/208873","sha":"ab9492c107a8ea2ca20bcb495f9c508a3b1e0037"}}]}] BACKPORT--> Co-authored-by: Matthew Kime <[email protected]>
javanna
added a commit
that referenced
this pull request
Mar 14, 2025
Frozen indices, the freeze index API and the private index.frozen setting have been removed with #120539. There is also a search throttled thread pool that can now be removed, as well as a private search.throttled index settings that is no longer used as it could only be set internally by freezing an index. While the index setting is private and can be removed, as it should no longer be present in any index on 9.0+ indices, the thread pool settings associated to the removed pool are still accepted as no-op in case users have customized them and are upgrading without removing these. These will also trigger a deprecating warning. This change also removes the search.throttled related output from the thread pool section of the cluster info API.
javanna
added a commit
to javanna/elasticsearch
that referenced
this pull request
Mar 14, 2025
Frozen indices, the freeze index API and the private index.frozen setting have been removed with elastic#120539. There is also a search throttled thread pool that can now be removed, as well as a private search.throttled index settings that is no longer used as it could only be set internally by freezing an index. While the index setting is private and can be removed, as it should no longer be present in any index on 9.0+ indices, the thread pool settings associated to the removed pool are still accepted as no-op in case users have customized them and are upgrading without removing these. These will also trigger a deprecating warning. This change also removes the search.throttled related output from the thread pool section of the cluster info API.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 14, 2025
Frozen indices, the freeze index API and the private index.frozen setting have been removed with #120539. There is also a search throttled thread pool that can now be removed, as well as a private search.throttled index settings that is no longer used as it could only be set internally by freezing an index. While the index setting is private and can be removed, as it should no longer be present in any index on 9.0+ indices, the thread pool settings associated to the removed pool are still accepted as no-op in case users have customized them and are upgrading without removing these. These will also trigger a deprecating warning. This change also removes the search.throttled related output from the thread pool section of the cluster info API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the transport action and the index setting.
The deprecation check has to go because the setting it uses to detect frozen indices has gone. We are issueing a critical deprecation warning in 8.last telling users to unfreeze them.
A lot of integration tests under
x-pack/plugin/sqlalso have to go, because they rely on being able to freeze indices.