Reintroduce common-analysis tests #120604
Conversation
elasticsearchmachine
added
needs:triage
drempapis
added
>non-issue
Team:Search Foundations
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
| { | ||
| IndexVersion version = IndexVersionUtils.randomVersionBetween( | ||
| random(), | ||
| IndexVersions.MINIMUM_READONLY_COMPATIBLE, |
There was a problem hiding this comment.
I have replaced the IndexVersions.V_7_0_0 with IndexVersions.MINIMUM_READONLY_COMPATIBLE. If you think that it is ok, we should also apply it to CommonAnalysisPluginTests and SynonymsAnalysisTests
There was a problem hiding this comment.
Yes, I think that is okay. I see the tests from #112570 regarding CommonAnalysisPluginTests and SynonymAnalysisTests are already rolled back, would you mind doing the suggested changes in this PR just for completeness?
There was a problem hiding this comment.
Thank you, @cbuescher, for the review. Yes, I'll make the update in this PR.
|
Thank you, LGTM. Left one little task for adapting the two tests that are already reverted. |
3 participants
Reintroduce tests deleted via #112570
Some of the classes were reverted in this work #118972