Skip to content

Esql Support date nanos on date diff function #120645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jan 23, 2025
Merged

Esql Support date nanos on date diff function #120645

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
e6c3c1f
refactor evaluator factory creation
not-napoleon Jan 21, 2025
2966244
mixed nanos/millis support
not-napoleon Jan 21, 2025
466624a
add CSV test
not-napoleon Jan 22, 2025
5dc21c5
[CI] Auto commit changes from spotless
Jan 22, 2025
f46f586
Update docs/changelog/120645.yaml
not-napoleon Jan 22, 2025
a29e482
Merge branch 'main' into esql-date-nanos-date-diff
not-napoleon Jan 22, 2025
7c450c6
add in the rest of the type tests
not-napoleon Jan 22, 2025
09c1c08
Merge remote-tracking branch 'refs/remotes/not-napoleon/esql-date-nan…
not-napoleon Jan 22, 2025
1c2e31a
Merge branch 'main' into esql-date-nanos-date-diff
not-napoleon Jan 22, 2025
e409072
response to PR feedback
not-napoleon Jan 23, 2025
1a6fd42
Merge branch 'main' into esql-date-nanos-date-diff
not-napoleon Jan 23, 2025
353ba15
[CI] Auto commit changes from spotless
Jan 23, 2025
1ba57e1
fix tests to reflect new varaible names
not-napoleon Jan 23, 2025
b35262c
Merge remote-tracking branch 'refs/remotes/not-napoleon/esql-date-nan…
not-napoleon Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions docs/changelog/120645.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
pr: 120645
summary: Esql Support date nanos on date diff function
area: ES|QL
type: enhancement
issues:
- 109999
144 changes: 144 additions & 0 deletions docs/reference/esql/functions/kibana/definition/date_diff.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions docs/reference/esql/functions/types/date_diff.asciidoc
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

23 changes: 23 additions & 0 deletions x-pack/plugin/esql/qa/testFixtures/src/main/resources/date_nanos.csv-spec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1249,3 +1249,26 @@ sv_nanos:date_nanos | a:keyword | b:keyword | c:keywo
2023-03-23T12:15:03.360103847Z | 2023-03-23T12:15:03.360Z | 2023-03-23 | 2023-03-23T12:15:03.360103847Z
2023-03-23T12:15:03.360103847Z | 2023-03-23T12:15:03.360Z | 2023-03-23 | 2023-03-23T12:15:03.360103847Z
;

Date Nanos Date Diff
required_capability: date_nanos_date_diff
required_capability: to_date_nanos

FROM date_nanos
| EVAL n = MV_MAX(nanos)
| EVAL diff_sec = DATE_DIFF("seconds", TO_DATE_NANOS("2023-10-23T12:15:03.360103847Z"), n)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add two extra cases for the combinations of millis and nanos? Maybe in this same test, as extra columns

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added one such.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, maybe another test with the first param coming from an index, as we don't test it here. From an index, or from a CASE(). Whatever, as long as it's not a constant

| KEEP diff_sec, n;
ignoreOrder:true

diff_sec:integer | n:date_nanos
5998 | 2023-10-23T13:55:01.543123456Z
5932 | 2023-10-23T13:53:55.832987654Z
5871 | 2023-10-23T13:52:55.015787878Z
5811 | 2023-10-23T13:51:54.732102837Z
4711 | 2023-10-23T13:33:34.937193000Z
745 | 2023-10-23T12:27:28.948000000Z
0 | 2023-10-23T12:15:03.360103847Z
0 | 2023-10-23T12:15:03.360103847Z
-18489600 | 2023-03-23T12:15:03.360103847Z
-18489600 | 2023-03-23T12:15:03.360103847Z
;
168 changes: 168 additions & 0 deletions ...ticsearch/xpack/esql/expression/function/scalar/date/DateDiffConstantMillisEvaluator.java
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading