[8.x] rrf support the window_size parameter to compatible with old version #120690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit be9fa86)
elasticsearchmachine
added
needs:triage
|
hi, @pmpailis, I add a new PR, can you help to review it? |
pmpailis
added
:Search Relevance/Ranking
elasticsearchmachine
added
Team:Search Relevance
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
|
Thanks @weizijun ! Changed the type to |
pmpailis
reviewed
Jan 23, 2025
x-pack/plugin/rank-rrf/src/yamlRestTest/resources/rest-api-spec/test/rrf/100_rank_rrf.yml
Outdated
Show resolved
Hide resolved
pmpailis
reviewed
Jan 23, 2025
x-pack/plugin/rank-rrf/src/yamlRestTest/resources/rest-api-spec/test/rrf/100_rank_rrf.yml
Outdated
Show resolved
Hide resolved
|
Thanks @weizijun ! Change looks fine to me. Let me also run the CI tests. |
|
buildkite test this please |
|
buildkite test this please |
|
buildkite test this please |
pmpailis
reviewed
Jan 24, 2025
|
buildkite test this please |
pmpailis
added
the
auto-backport
|
Thank you for the PR and all the iterations @weizijun ! Will proceed to merging to |
pmpailis
approved these changes
Jan 27, 2025
💔 Backport failed
You can use sqren/backport to manually backport by running |
This was referenced Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
where upgrade from 8.13 to 8.17 or newer version, the java client will failed when use rrf and window_size parameter.
I added the
window_sizeparameter back to the deprecated parameters to support upgrades.This PR add the deprecated parameter to 8.x branch, because the feature will remove in 9.x.
More detail, see #119724